Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Self-attentive Sentence Embedding Tutorial Undeclared Dependency (sklearn) #886

Closed
szha opened this issue Aug 18, 2019 · 2 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@szha
Copy link
Member

szha commented Aug 18, 2019

Description

self-attentive sentence embedding tutorial is using sklearn for accuracy and f1. As we didn't take sklearn as a dependency, we should migrate those usage to the accuracy/f1 in mxnet and drop the dependency in docker

@szha szha added the bug Something isn't working label Aug 18, 2019
@szha szha added the good first issue Good for newcomers label Aug 28, 2019
@avinashsai
Copy link
Member

@szha
I have the code ready with sklearn accuracy metric changed to mxnet accuracy metric. However, mxnet F1 currently supports binary classification. However, this tutorial is a multi-class classification and hence will not be able to use mxnet F1 metric. Should I submit PR only with accuracy changed or leave it as it is??

@leezu
Copy link
Contributor

leezu commented Apr 23, 2020

@avinashsai you may be interested in the mxnet metrics improvements for mxnet 2: apache/mxnet#18083

If you have the code ready, it's good to submit the part that can be supported by mxnet metric

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants