Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

[question] why just replace the inline keyword with predefined macro? #79

Open
dzhwinter opened this issue Nov 30, 2015 · 1 comment
Open

Comments

@dzhwinter
Copy link

This is just a question about the source code. To improve the performance, it will be benefit to use inline function as many as possible. The MSHADOW_XINLINE is a force inline macro which defined in base.h. But sometimes inline key word appear here and there.
for example,
https://github.com/dmlc/mshadow/blob/master/mshadow/expression.h#L137
why just replace the inline keyword with predefined macro? Is it matter the performance?
Or just use inline keywords where we can make sure that function will be execute in CPU .

@szha
Copy link
Member

szha commented Aug 4, 2019

This code base has been donated to the Apache MXNet project per #373, and repo is deprecated. Future development and issue tracking should continue in Apache MXNet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants