You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Assume we don't expect to re-assign new environment variables once we already assigned non-empty values, it might be better if we first check whetherEnvironment::kvs is empty, if it's empty, we can do this assignment, otherwise, we won't.
If I'm on the track, would like to make a PR.
Thanks.
The text was updated successfully, but these errors were encountered:
Looks like sometimes this assignment
env->kvs = envs;
in the body ofEnvironment::Init
method in env.h (ps-lite/include/ps/internal/env.h
Line 36 in db61897
Assume we don't expect to re-assign new environment variables once we already assigned non-empty values, it might be better if we first check whether
Environment::kvs
is empty, if it's empty, we can do this assignment, otherwise, we won't.If I'm on the track, would like to make a PR.
Thanks.
The text was updated successfully, but these errors were encountered: