Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hides overloaded virtual function #176

Open
leezu opened this issue Jun 9, 2020 · 0 comments
Open

hides overloaded virtual function #176

leezu opened this issue Jun 9, 2020 · 0 comments

Comments

@leezu
Copy link
Contributor

leezu commented Jun 9, 2020

On clang7

[2020-06-09T02:55:09.278Z] /work/mxnet/3rdparty/ps-lite/include/ps/kv_app.h:417:8: error: 'ps::KVServer<char>::set_request_handle' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
[2020-06-09T02:55:09.278Z]   void set_request_handle(const ReqHandle& request_handle) {
[2020-06-09T02:55:09.278Z]        ^
[2020-06-09T02:55:09.278Z] /work/mxnet/src/kvstore/./kvstore_dist_server.h:159:22: note: in instantiation of template class 'ps::KVServer<char>' requested here
[2020-06-09T02:55:09.278Z]     ps_server_ = new ps::KVServer<char>(0);
[2020-06-09T02:55:09.278Z]                      ^
[2020-06-09T02:55:09.278Z] /work/mxnet/3rdparty/ps-lite/include/ps/simple_app.h:83:23: note: hidden overloaded virtual function 'ps::SimpleApp::set_request_handle' declared here: type mismatch at 1st parameter ('const ps::SimpleApp::Handle &' (aka 'const function<void (const ps::SimpleData &, ps::SimpleApp *)> &') vs 'const ps::KVServer<char>::ReqHandle &' (aka 'const function<void (const ps::KVMeta &, const KVPairs<char> &, ps::KVServer<char> *)> &'))
[2020-06-09T02:55:09.278Z]   virtual inline void set_request_handle(const Handle& request_handle) {
[2020-06-09T02:55:09.278Z]                       ^
[2020-06-09T02:55:09.278Z] In file included from /work/mxnet/src/kvstore/kvstore.cc:25:
[2020-06-09T02:55:09.278Z] In file included from /work/mxnet/include/mxnet/kvstore.h:37:
[2020-06-09T02:55:09.278Z] In file included from /work/mxnet/3rdparty/ps-lite/include/ps/ps.h:13:
[2020-06-09T02:55:09.278Z] /work/mxnet/3rdparty/ps-lite/include/ps/kv_app.h:427:8: error: 'ps::KVServer<char>::Response' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
[2020-06-09T02:55:09.278Z]   void Response(const KVMeta& req, const KVPairs<Val>& res = KVPairs<Val>());
[2020-06-09T02:55:09.278Z]        ^
[2020-06-09T02:55:09.278Z] /work/mxnet/3rdparty/ps-lite/include/ps/simple_app.h:69:23: note: hidden overloaded virtual function 'ps::SimpleApp::Response' declared here: type mismatch at 1st parameter ('const ps::SimpleData &' vs 'const ps::KVMeta &')
[2020-06-09T02:55:09.278Z]   virtual inline void Response(const SimpleData& recv_req, const std::string& res_body = "");
[2020-06-09T02:55:09.278Z]                       ^
[2020-06-09T02:55:09.278Z] 2 errors generated.

triggered by apache/mxnet#18513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant