[Relay/TOPI][Op] Add batch_matmul in relay and TOPI #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinghai
reviewed
Feb 4, 2019
topi/python/topi/x86/nn.py
Outdated
|
|
||
| @generic.schedule_batch_dot.register(["cpu"]) | ||
| def schedule_batch_dot(outs): | ||
| """Schedule for softmax |
|
Given the description of the computation, batch_matmul might be a more general name? |
|
@yinghai Yes, I agree. I'll update it in the new commit. |
icemelon
changed the title
Laurawly
reviewed
Feb 15, 2019
| def test_batch_matmul(): | ||
| verify_batch_matmul(1, 16, 16, 32) | ||
| verify_batch_matmul(5, 16, 16, 32) | ||
| verify_batch_matmul(5, 16, 20, 32) |
There was a problem hiding this comment.
Maybe more test cases with batch size > 16?
There was a problem hiding this comment.
Added test case for larger batch size.
Laurawly
approved these changes
Feb 19, 2019
|
@ZihengJiang test_quantize_pass failed. Could you set rtol to a higher threshold? |
|
@icemelon9 can you try rebase and try to get it in? |
|
Sure. But I'm still waiting on @ZihengJiang to fix the quantize pass test case. |
|
Thanks @icemelon9 @yinghai @ZihengJiang , this is now merged. |
bwasti
pushed a commit
to facebookexperimental/tvm
that referenced
this pull request
Mar 6, 2019
* Add batch_dot and cpu schedule * Add relay support for batch_dot * Rename batch_dot to batch_matmul * nits * Add missing file * Put batch_matmul and dense x86 schedule in separate files * Fix pylint * Remove unused import * Add cuda schedule for batch_matmul * Add test case with larger batch size * Add batch_matmul in api doc * Fix quantize pass rounding error * Fix pylint and minor change * bug fix
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
* Add batch_dot and cpu schedule * Add relay support for batch_dot * Rename batch_dot to batch_matmul * nits * Add missing file * Put batch_matmul and dense x86 schedule in separate files * Fix pylint * Remove unused import * Add cuda schedule for batch_matmul * Add test case with larger batch size * Add batch_matmul in api doc * Fix quantize pass rounding error * Fix pylint and minor change * bug fix
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* Add batch_dot and cpu schedule * Add relay support for batch_dot * Rename batch_dot to batch_matmul * nits * Add missing file * Put batch_matmul and dense x86 schedule in separate files * Fix pylint * Remove unused import * Add cuda schedule for batch_matmul * Add test case with larger batch size * Add batch_matmul in api doc * Fix quantize pass rounding error * Fix pylint and minor change * bug fix
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* Add batch_dot and cpu schedule * Add relay support for batch_dot * Rename batch_dot to batch_matmul * nits * Add missing file * Put batch_matmul and dense x86 schedule in separate files * Fix pylint * Remove unused import * Add cuda schedule for batch_matmul * Add test case with larger batch size * Add batch_matmul in api doc * Fix quantize pass rounding error * Fix pylint and minor change * bug fix
|
In some cases relay.build hangs. The issue caused by More info https://discuss.tvm.ai/t/relay-build-hangs-for-5d-max-pool3d-reshape-matmul/5398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to add batch_dot op in both TOPI and Relay.