-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Runtime] Enable option to use OpenMP thread pool #4089
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8c96d8b
[TVM] Add an option to use OMP thread pool
icemelon 36782fb
fix
icemelon 995682e
lint
icemelon d53403e
fix
icemelon 880f4a1
update
icemelon 097660f
fix
icemelon 984cd50
clean up
icemelon 794da1a
fix
icemelon dd340e3
fix for windows
icemelon 115cac5
fix
icemelon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
# OpenMP Module | ||
if(USE_OPENMP STREQUAL "gnu") | ||
find_package(OpenMP) | ||
if(OPENMP_FOUND) | ||
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}") | ||
list(APPEND TVM_RUNTIME_LINKER_LIBS ${OpenMP_CXX_LIBRARIES}) | ||
add_definitions(-DTVM_THREADPOOL_USE_OPENMP=1) | ||
message(STATUS "Build with OpenMP ${OpenMP_CXX_LIBRARIES}") | ||
else() | ||
add_definitions(-DTVM_THREADPOOL_USE_OPENMP=0) | ||
message(WARNING "OpenMP cannot be found, use TVM threadpool instead.") | ||
endif() | ||
elseif(USE_OPENMP STREQUAL "intel") | ||
find_package(OpenMP) | ||
if(OPENMP_FOUND) | ||
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}") | ||
if (MSVC) | ||
find_library(OMP_LIBRARY NAMES libiomp5md) | ||
else() | ||
find_library(OMP_LIBRARY NAMES iomp5) | ||
endif() | ||
list(APPEND TVM_RUNTIME_LINKER_LIBS ${OMP_LIBRARY}) | ||
add_definitions(-DTVM_THREADPOOL_USE_OPENMP=1) | ||
message(STATUS "Build with OpenMP " ${OMP_LIBRARY}) | ||
else() | ||
add_definitions(-DTVM_THREADPOOL_USE_OPENMP=0) | ||
message(WARNING "OpenMP cannot be found, use TVM threadpool instead.") | ||
endif() | ||
else() | ||
add_definitions(-DTVM_THREADPOOL_USE_OPENMP=0) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part assumes that
need_sync==1
, which is the de facto default now, but we probably need to keep the same logical behavior with the existing thread pool. Another option is to removeneed_sync
from the code. @tqchen Do you want to talk about if we still wantneed_sync
inThreadPool::Launch()
? https://github.com/dmlc/tvm/blob/master/src/runtime/thread_pool.cc#L298There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need_sync is used to generate barriers. if we do openmp, perhaps we can ignore it and just use omp's barrier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done