Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter names aren't validated #5568

Closed
Kodiologist opened this issue Apr 20, 2020 · 2 comments · Fixed by #5569
Closed

Parameter names aren't validated #5568

Kodiologist opened this issue Apr 20, 2020 · 2 comments · Fixed by #5569

Comments

@Kodiologist
Copy link
Contributor

Kodiologist commented Apr 20, 2020

With the latest XGBoost (9c1103e) on R, no error or warning seems to be produced for unrecognized parameter names, despite #5157.

> library(xgboost)
> m = xgboost(params = list(gama = 2), nrounds = 10, data = as.matrix(mtcars[, c("disp", "hp", "drat")]), label = mtcars$mpg)
@trivialfis
Copy link
Member

trivialfis commented Apr 20, 2020

I'm enabling parameter validation interface by interface, only went through 2 Python interfaces (normal train and scikit-learn). You can try to set validate_parameters to TRUE on R to see if it helps.

Will test through R package for validation as the next step, just being careful so that users won't silent XGBoost due to false alarms.

@Kodiologist
Copy link
Contributor Author

validate_parameters = TRUE indeed prints Parameters: { gama } might not be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants