Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Add more {lintr} linters and run them in CI #5779

Closed
jameslamb opened this issue Jun 11, 2020 · 1 comment
Closed

[R] Add more {lintr} linters and run them in CI #5779

jameslamb opened this issue Jun 11, 2020 · 1 comment

Comments

@jameslamb
Copy link
Contributor

Opening this issue from the discussion in #5778 , specifically #5778 (comment).

As of this writing there is some {lintr} code for linting the R package, but it is disabled

# lintr::expect_lint_free(linters=my_linters) # uncomment this if you want to check code quality
.

How to close this issue

  1. Enable linting in R-package/tests/testthat/test_lint.R (or propose an alternative way to run linting checks, such as https://github.com/microsoft/LightGBM/blob/4d43e96bbc10de2937aa70a5829977d46bdb1852/.ci/test.sh#L57
  2. Propose additional linters to be added. The list of available linters can be found here
@hcho3
Copy link
Collaborator

hcho3 commented Jul 16, 2020

Consolidating to #5796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants