-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoLD issue in xgb.train and/or xgb.attr #5935
Comments
Probably due to floating point error.
Seems pretty consistent at the displayed precision. |
Thanks for the quick reply @trivialfis. I agree the numbers do seem pretty consistent but they are not the same according to CRAN. Is there a way to check if this error is indeed attributable to XGBoost? I have been looking at the discussion at the link below but can't find find any such issue in my own R code. |
Could you try again after we merge #5934 ? Without a way to reproduce it, I can only make guesses. |
@trivialfis I was able to create a reproducible example of the issue using only the xgboost package and the titanic dataset from the Since testing with R (NoLD) was a bit of a challenge, at least for me, I created a docker image (vnijs/nold) with R-devel NoLD on Ubuntu with Rstudio and build tools available. See the repo (vnijs/NoLD/README.md) and dockerhub repo linked below. Please do let me know if I can help in any way. https://github.com/vnijs/NoLD
|
Let me try looking into it tomorrow. |
@vnijs Hello, I had a chance to look at your script. I was not able to reproduce the error on my machine. Commands I ran:
Output:
|
Thanks for following up @hcho3. I can reproduce with xgboost 1.1.1.1, which was the version on CRAN when I posted this. I installed the latest version just now inside the container but I'm still getting the same issue (see output below). Is your test.R script exactly the same as my code below? I assume so, but that is the only thing I can think of at the moment
|
@vnijs Yes, I used the same code that you posted. |
@vnijs Interesting, the error is only thrown when I run the script inside an interactive session. |
For some reason,
|
Indeed,
|
CRAN has notified me of a NoLD problem in one of my R-packages that seems to be attributable to XGBoost. Unfortunately I haven't been able to figure out a way to test the NoLD setup that CRAN has without actually submitting the package to CRAN. If you could provide any assistance to help figure out where the issue is coming from so I can report back to CRAN without getting several of my packages archived that we be wonderful.
https://www.stats.ox.ac.uk/pub/bdr/noLD/radiant.model.out
Relevant source code: https://github.com/radiant-rstats/radiant.model/blob/master/R/gbt.R
The text was updated successfully, but these errors were encountered: