Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise SerializationTest to make it more robust with CUDA 10.x and 11.x #5983

Closed
hcho3 opened this issue Aug 5, 2020 · 2 comments
Closed

Comments

@hcho3
Copy link
Collaborator

hcho3 commented Aug 5, 2020

#5808 added support for CUDA 11, and @canonizer reported that the SerializationTest test was succeeding with CUDA 10 but failing for CUDA 11. For now, we worked around it by increasing the data size, but we should make the test more robust.

@trivialfis
Copy link
Member

It's a tough problem, like any issue related to floating error. On the one hand we don't want to relax the test too much, the serialization tests catch a lots of bugs during development. On the other hand floating error can cause structural changes in trees so in that case we don't actually have anything to assert. If you have suggestions feel free to share, I would be happy to look into them.

@trivialfis
Copy link
Member

Fixed by #7446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants