You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, important functions such as feature importances and evaluation metrics rely on parsing of text strings, specifically the text output from the model dump function. For example:
Looked into this a little bit. The implementation isn't difficult, but depends on #6605 due to the use of feature names/types. I will try to figure out a better way to store those information.
Currently, important functions such as feature importances and evaluation metrics rely on parsing of text strings, specifically the text output from the model dump function. For example:
xgboost/python-package/xgboost/core.py
Lines 1797 to 1832 in 68c55a3
xgboost/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/Booster.java
Lines 509 to 540 in 68c55a3
xgboost/python-package/xgboost/training.py
Lines 85 to 91 in 68c55a3
xgboost/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/Booster.java
Lines 240 to 255 in 68c55a3
Also see #4665 (comment) #4665 (comment)
We should aim to eliminate all such uses of text parsing, since a slight change in the text dump will cause all these functions to break.
Proposed replacement:
Now that we have a functioning JSON library as well as numeric printing function (
charconv
) in XGBoost, it should be doable.The text was updated successfully, but these errors were encountered: