You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changed of schedule per discussed here: #429 (comment)
If any counter suggestion is welcome on the thread above ^
General topics
DMN model -under-test and their InputData node typeRef
It has been requested that DMN-models-under-test do specify typeRef for the InputData nodes.
After evaluating all possible scenarios (test with or without a typechecker for conversion and/or coercion, etc), the below seem the more inclusive compromise and common-ground approach:
For DMN model under test the InputData nodes in the model SHALL specify typeRef
The InputData typeRef SHOULD be as precise as possible (if the test is supplying a number as an input, the InputData should be typeRef="number")
There might be cases where:
the test should work generically on the supplied inputs (the specific input maybe a number or maybe a string)
and there might be other cases where the intention of the test is to leverage the typecheck/conversion/coercion.
In this and similar cases, it would be better for the DMN models under test to specify the InputData nodes typeRef="Any".
typeRef of BKMs (and Invocables)
The type of the variable, holds the same type of the expression decision logic; in DMN1.x this was raised that for Invocables then naturally this is a function.
So for BKMs, it is argumented the typeRef of the BKM's <variable> is a function, the typeRef of the <encapsulatedLogic> is also a function (since it must be the same type of the sibling variable), and therefore the output-type is expressed as the typeRef of the encapsulatedLogic's body.
To be checked if this understanding is consistent when DT are the body of an encapsulatedLogic.
names for DRG nodes
This is something @tarilabs wanted to discuss with @StrayAlien too, we will do at the next chance.
needs amendments per the discussion (@tarilabs will follow-up with @StrayAlien on these) and so are moved to the next iterations (as we could expect these could be aligned quite quickly).
Action items
@tarilabs will check if it's possible to put in the TCK validator a check on the InputData typeRef @tarilabs will followup with @StrayAlien on the open PRs which are proposed for the next milestone to include the typeRef in the InputData nodes (https://github.com/dmn-tck/tck/milestone/4) @opatrascoiu will inform if other DMN model under test in the current suite of tests of TCK have InputData's typeRef missing
AOB
We're sorry we missed on @StrayAlien and @SimonRinguette for this meeting. If you have an alternatively schedule which can be more suitable if you want to participate in the meeting, don't hesitate to let us know.
New tests for Vendors
As a result of this meeting, new tests have been merged.
Vendors are invite to submit refreshed results by 2021-04-30 to be included automatically in the website refresh which will be next scheduled for May 1st 2021.
(as always, Vendors are free to submit anytime, and beyond the regular website refresh we can always perform a one-off refresh on Vendor's request no problem)
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Welcome to the April 2021 meeting of the DMN TCK
Logistics
Changed of schedule per discussed here: #429 (comment)
If any counter suggestion is welcome on the thread above ^
General topics
DMN model -under-test and their InputData node typeRef
It has been requested that DMN-models-under-test do specify
typeRef
for the InputData nodes.After evaluating all possible scenarios (test with or without a typechecker for conversion and/or coercion, etc), the below seem the more inclusive compromise and common-ground approach:
typeRef of BKMs (and Invocables)
The type of the variable, holds the same type of the expression decision logic; in DMN1.x this was raised that for Invocables then naturally this is a function.
So for BKMs, it is argumented the
typeRef
of the BKM's<variable>
is a function, thetypeRef
of the<encapsulatedLogic>
is also a function (since it must be the same type of the sibling variable), and therefore the output-type is expressed as thetypeRef
of the encapsulatedLogic's body.To be checked if this understanding is consistent when DT are the body of an encapsulatedLogic.
names for DRG nodes
This is something @tarilabs wanted to discuss with @StrayAlien too, we will do at the next chance.
Open PRs
Out of the proposed https://github.com/dmn-tck/tck/milestone/3, for the discussion in the meeting and PR pages, we could convene to merge: #392
The other 2 PRs:
needs amendments per the discussion (@tarilabs will follow-up with @StrayAlien on these) and so are moved to the next iterations (as we could expect these could be aligned quite quickly).
Action items
@tarilabs will check if it's possible to put in the TCK validator a check on the InputData typeRef
@tarilabs will followup with @StrayAlien on the open PRs which are proposed for the next milestone to include the typeRef in the InputData nodes (https://github.com/dmn-tck/tck/milestone/4)
@opatrascoiu will inform if other DMN model under test in the current suite of tests of TCK have InputData's typeRef missing
AOB
We're sorry we missed on @StrayAlien and @SimonRinguette for this meeting. If you have an alternatively schedule which can be more suitable if you want to participate in the meeting, don't hesitate to let us know.
New tests for Vendors
As a result of this meeting, new tests have been merged.
Vendors are invite to submit refreshed results by 2021-04-30 to be included automatically in the website refresh which will be next scheduled for May 1st 2021.
(as always, Vendors are free to submit anytime, and beyond the regular website refresh we can always perform a one-off refresh on Vendor's request no problem)
Beta Was this translation helpful? Give feedback.
All reactions