Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back button doesn't work on browers #138

Open
jbloom opened this issue May 6, 2020 · 3 comments
Open

back button doesn't work on browers #138

jbloom opened this issue May 6, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jbloom
Copy link
Contributor

jbloom commented May 6, 2020

@skhilton, I was using this to look at @tylernstarr's links to dms-view. For instance, see here, he has a link partway down the page (in hyperlinked blue). The link dms-view works fine, but the back button in the browser doesn't go back to the prior page.

@skhilton
Copy link
Collaborator

skhilton commented May 6, 2020

@jbloom, I am pretty sure this behavior is a consequence of the URL tracking. I believe when you click the "back" button, the tool cycles through different updates to the URL that happens when you load the tool. The reason that I think this is the case is because if you hit "back" a lot you end up back at the previous page you expect.

This is probably not a high-priority fix for two reasons. 1. It would require a large refactor at the moment and 2. there is a work around. If you ctrl-click on a link, it opens in a new tab and you don't have this problem. Do you think this is reasonable or do you think this should be a higher priority?

@jbloom
Copy link
Contributor Author

jbloom commented May 6, 2020

If it's hard to fix, I think it's fine to keep as is.

@skhilton
Copy link
Collaborator

skhilton commented May 6, 2020

Great, I'll mark it as an enhancement.

@skhilton skhilton added the enhancement New feature or request label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants