feat(mouse button): Allow to specify button option for realMouseDown and realMouseUp
#201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` and `realMouseUp`
Andarist
force-pushed
the
support-button-option
branch
from
8f1c5cb
to
cad18f1
Compare
Andarist
commented
Dec 3, 2021
| @@ -42,9 +48,9 @@ export async function realMouseDown( | |||
| x, | |||
| y, | |||
| clickCount: 1, | |||
| buttons: 1, | |||
| buttons: mouseButtonNumbers[options.button ?? "left"], | |||
There was a problem hiding this comment.
btw. configuring buttons is not necessary unless we have additional buttons pressed down. It's not possible to configure this right now so this could be omitted - but I'd like to add that feature in the future, so it's convenient to leave this here for the time being.
|
@dmtrKovalenko friendly 🏓 |
dmtrKovalenko
approved these changes
Dec 27, 2021
dmtrKovalenko
pushed a commit
that referenced
this pull request
Feb 11, 2022
…` and `realMouseUp` (#201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.