Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make cy.realPress {enter} to be functional for accessibility navigation #69

Conversation

noahgelman
Copy link
Contributor

@noahgelman noahgelman commented May 3, 2021

Closes #8

Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, you are the superhero of enters! Cool :)

If it works I will be happy to merge this, but we need to verify that it will work as expected with regular text areas and break the word and also make a test that verifies that it works as expected for focused buttons!

@dmtrKovalenko dmtrKovalenko changed the title Modified keyDown event to allow {enter} to be functional feat: Make cy.press {enter} to be functional for accessibility navigation May 3, 2021
@dmtrKovalenko dmtrKovalenko changed the title feat: Make cy.press {enter} to be functional for accessibility navigation feat: Make cy.realPress {enter} to be functional for accessibility navigation May 3, 2021
@dmtrKovalenko dmtrKovalenko merged commit 712899e into dmtrKovalenko:develop May 31, 2021
@dmtrKovalenko
Copy link
Owner

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.realPress('{enter}') does not trigger buttons, .realPress('Space') does
3 participants