Skip to content

Commit 33472fd

Browse files
stephanwleedna2github
authored andcommitted
layout: make resizer smaller (tensorflow#5390)
Previously, we used to have a little icon and thick vertical bar to make resize affordance apparent on the left pane resizer. After surveying modern apps, it looks like they are often done with pointer in combination with thicker vertical bar on hover so we adopt those designs. In the end, with this change, we give users about 18 pixels back in the horizontal space.
1 parent 49d3ecf commit 33472fd

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

tensorboard/webapp/core/views/layout_container.scss

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,36 @@ limitations under the License.
3030
.expand {
3131
@include tb-theme-foreground-prop(border-color, border);
3232
box-sizing: border-box;
33-
flex: 0 0 20px;
33+
flex: 0 0;
3434
justify-self: stretch;
35+
}
36+
37+
.expand {
3538
width: 20px;
3639
}
3740

3841
.resizer {
3942
align-items: center;
4043
border-style: solid;
41-
border-width: 0 1px;
44+
border-width: 0 2px;
4245
cursor: ew-resize;
4346
display: flex;
4447
justify-self: stretch;
4548

4649
.mat-icon {
4750
width: 100%;
4851
}
52+
53+
&:hover {
54+
border-color: #ccc;
55+
outline: 3px solid #ccc;
56+
z-index: 1;
57+
58+
@include tb-dark-theme {
59+
outline-color: #777;
60+
border-color: #777;
61+
}
62+
}
4963
}
5064

5165
.expand {

tensorboard/webapp/core/views/layout_container.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ import {MouseEventButtons} from '../../util/dom';
4949
*ngIf="(width$ | async) > 0"
5050
class="resizer"
5151
(mousedown)="resizeGrabbed()"
52-
>
53-
<mat-icon svgIcon="drag_indicator_24px"></mat-icon>
54-
</div>
52+
></div>
5553
<ng-content select="[main]"></ng-content>
5654
`,
5755
styleUrls: ['layout_container.css'],

0 commit comments

Comments
 (0)