Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Lodash 3.x Update #111

Closed
marcelgerber opened this issue Apr 7, 2015 · 4 comments
Closed

Upcoming Lodash 3.x Update #111

marcelgerber opened this issue Apr 7, 2015 · 4 comments

Comments

@marcelgerber
Copy link

Dear Brackets extension developer,
we're planning to update the version of Lodash used in Brackets to 3.x (currently, we use 2.4.1).
As we've had a look at your extension, we noticed there's some code that may cause issues while migrating. Thus, we suggest to update your extension so the migration can happen frictionless.
For your extension, we've identified this issue:
Multiple places: _.template with more than 1 parameter won't be supported any more. Instead, use the new syntax _.template(string)(data)

Further information:
Lodash compatibility warnings
Brackets issue about updating Lodash

@dnbard
Copy link
Owner

dnbard commented Apr 8, 2015

Thanks! Any estimate when Brackets will start using the new Lodash ?

@marcelgerber
Copy link
Author

Ah, important to mention: The solution I suggested works in both Lodash 2.4.1 and Lodash 3.x, so you can safely do the transition now.

@marcelgerber
Copy link
Author

@dnbard Did you already have a look at the transition suggested here?

@dnbard dnbard closed this as completed in 3fadbf8 Apr 20, 2015
@dnbard
Copy link
Owner

dnbard commented Apr 20, 2015

@marcelgerber Yes, everything is should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants