fix(InfoCard): change text props to React.ReactNode #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 187fa4e:
|
AadneRo
approved these changes
Feb 2, 2022
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 10m PerformanceLighthouse report
|
tujoworker
pushed a commit
that referenced
this pull request
Feb 2, 2022
# [9.20.0](v9.19.0...v9.20.0) (2022-02-02) ### Bug Fixes * add stylis plugin TS Type definitions ([4c8210c](4c8210c)) * **AvatarGroup:** remove left border from first avatar ([#1254](#1254)) ([bc1a870](bc1a870)) * **Breadcrumb:** fix React Node usage in aria-label ([1c921fa](1c921fa)) * **BreadCrumb:** make isCollapsed prop typing strict to only use boolean ([392e6eb](392e6eb)) * **CodeHighlighting:** ensure a scrollbar is shown when not enough space is available (pre tag) ([#1230](#1230)) ([4bd2930](4bd2930)) * **InfoCard:** change text props to React.ReactNode ([#1253](#1253)) ([79c37af](79c37af)) * label of avatar group to be react node ([#1244](#1244)) ([04df401](04df401)) * label of tag group to be react node ([#1245](#1245)) ([4949d85](4949d85)) * make Eufemia "warn" log better recognizable ([#1231](#1231)) ([c917b94](c917b94)) * **StepIndicator:** fix height animation issue when CSS is loaded too slow ([#1221](#1221)) ([8dfdd7e](8dfdd7e)) * **TagGroup:** make TagGroup component inline, so it can be used in body text / paragraphs ([#1229](#1229)) ([b64f5d3](b64f5d3)) * **TimeLine:** display skeleton when items is passed as children ([#1255](#1255)) ([4eaea6b](4eaea6b)) * **Timeline:** fix TypeScript issue when using children ([0a9571c](0a9571c)) * **Types:** correct usage of icon types inside Button and BreadcrumbItem ([85dee9c](85dee9c)) * **Types:** correct usage of title and size attributes along side with some other colliding props ([540998a](540998a)) * **Types:** fix SkeletonShow type usage ([03c8525](03c8525)) ### Features * add usePropsWithContext hook for hook based components ([#1234](#1234)) ([d60feeb](d60feeb)) * remove type="module" in order omit the "fullySpecified" spec ([bc3f12a](bc3f12a)) * **TypeScript:** enhance overall typing and add verify check ([608bede](608bede))
|
🎉 This PR is included in version 9.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for wanting to change from string to React.ReactNode is because we often pass in translations in pm-netbank, like
<FormattedMessage>, etc.