feat(TypeScript): remove original ts/tsx files and only leave type definition files #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b08cb95:
|
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 10m PerformanceLighthouse report
|
tujoworker
force-pushed
the
feat/build-ts-definitions-only
branch
from
9c702f2 to
68aeb26
Compare
dinarosv
approved these changes
Feb 16, 2022
|
A second beta was released in corporation with the issue reporter. |
tujoworker
pushed a commit
that referenced
this pull request
Feb 21, 2022
# [9.23.0-beta.4](v9.23.0-beta.3...v9.23.0-beta.4) (2022-02-21) ### Bug Fixes * **Dropdown:** disabled tertiary dropdown ([c1b4c4b](c1b4c4b)) * **Styles:** ensure independent styling packages have declared their dependencies ([8b3c230](8b3c230)) ### Features * **esm:** remove esm directory in package build ([f189b62](f189b62)) * **Icon:** add examples for color property ([#1275](#1275)) ([67f8121](67f8121)) * **Tabs:** Enhance parent width handling and remove auto edge detection ([d002f2c](d002f2c)) * **TypeScript:** remove original ts/tsx files and only leave type definition files ([#1292](#1292)) ([79bdfb4](79bdfb4))
|
🎉 This PR is included in version 9.23.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tujoworker
pushed a commit
that referenced
this pull request
Feb 22, 2022
# [9.23.0](v9.22.0...v9.23.0) (2022-02-22) ### Bug Fixes * **Dropdown:** disabled tertiary dropdown ([c1b4c4b](c1b4c4b)) * **Modal:** add possibility for camelcase props ([4127452](4127452)) * **ProgressIndicator:** css change to fix aliasing artifacts for ProgressIndicator ([ab8859e](ab8859e)) * set Eufemia.version during release ([e74d441](e74d441)) * **Styles:** ensure independent styling packages have declared their dependencies ([8b3c230](8b3c230)) * **Tabs:** align to new UX designs ([794bf70](794bf70)) * **Tag:** fix Tag.Group spacing ([d7b77a2](d7b77a2)) ### Features * **esm:** remove esm directory in package build ([f189b62](f189b62)) * **Icon:** add examples for color property ([#1275](#1275)) ([67f8121](67f8121)) * Separate Drawer and Dialog from Modal ([ebe8e6a](ebe8e6a)) * **Tabs:** Enhance parent width handling and remove auto edge detection ([99ed393](99ed393)) * **TypeScript:** remove original ts/tsx files and only leave type definition files ([#1292](#1292)) ([79bdfb4](79bdfb4))
|
🎉 This PR is included in version 9.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are setups and cases where it is not recommended to have
.tsxfiles insidenode_modules. Until now we have just published the raw ts source files in order to let projects use the types of our ts components, while we had definition files for the rest.With this PR – we change this, so we only end up with definitions files.
I will squash all commits on pr merge. But the intention is to get out a beta version first.
Here is the beta release and the ci logs