Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add more information on converting from Modal #1308

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

dinarosv
Copy link
Contributor

To prevent misinterpretation and errors when trying to convert from Modal to Drawer or Dialog 😊

@dinarosv dinarosv requested a review from tujoworker February 23, 2022 13:36
@tujoworker tujoworker changed the title docs: add more information on converting from Modal fix(docs): add more information on converting from Modal Feb 23, 2022
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks 🙌

Let me know what do you think – but in order to make it visible in the change log, we can use the "fix" decoration to bold out that change. I'v the pr title already. If you agree, you simply can squash merge.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83faca5:

Sandbox Source
eufemia-starter Configuration

@dinarosv dinarosv merged commit 1cce729 into main Feb 23, 2022
@dinarosv dinarosv deleted the docs/modal-convert branch February 23, 2022 13:56
tujoworker pushed a commit that referenced this pull request Feb 23, 2022
## [9.23.1](v9.23.0...v9.23.1) (2022-02-23)

### Bug Fixes

* **docs:** add more information on converting from Modal ([#1308](#1308)) ([1cce729](1cce729))
* **docs:** fix event docs of InfoCard ([2ccd670](2ccd670))
* **InfoCard:** issue on smaller screens ([9512980](9512980))
* **Internal:** ensure usePropsWithContext will use context regardless ([0a7e9c6](0a7e9c6))
* **Modal:** containerPlacement bug for left side ([15c0442](15c0442))
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants