fix(InputMasked): fix integerLimit to work during typing #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8993e19:
|
✅ DNB Eufemia Portal deploy preview ready
|
|
It looks like the limit stops at 8 integers even though the limit is set to 10. Is it counting the spaces maybe? |
|
yes, good point. Will fix that 👍 |
tujoworker
force-pushed
the
fix/input-masked-limit
branch
from
9ac75fb to
8993e19
Compare
|
@jorgenholme Can you check if the latest changes work as expected? Here are the changes. |
jorgenholme
approved these changes
Nov 4, 2022
|
Looks great 💯 |
tujoworker
pushed a commit
that referenced
this pull request
Nov 7, 2022
# [9.37.0](v9.36.0...v9.37.0) (2022-11-07) ### Bug Fixes * **InputMasked:** fix integerLimit to work during typing ([#1694](#1694)) ([0fb697d](0fb697d)) * **Table:** remove usage of pseudo elements inside table rows ([#1704](#1704)) ([3f678bd](3f678bd)) * **Td:** fix children and add tests ([#1703](#1703)) ([060e84f](060e84f)) ### Features * add e_scooter icon ([#1701](#1701)) ([c7024e2](c7024e2))
|
🎉 This PR is included in version 9.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is reprod of the bug.