Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Th): add table header sortable props #1706

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

tujoworker
Copy link
Member

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6fbc3fe:

Sandbox Source
eufemia-starter Configuration

@tujoworker tujoworker force-pushed the feat/table-header-props branch 2 times, most recently from fb5566f to 874b6ad Compare November 7, 2022 21:07
@gatsby-cloud
Copy link

gatsby-cloud bot commented Nov 7, 2022

✅ DNB Eufemia Portal deploy preview ready

@tujoworker tujoworker requested a review from langz November 8, 2022 05:21
@tujoworker tujoworker force-pushed the feat/table-header-props branch from 874b6ad to 6fbc3fe Compare November 8, 2022 07:42
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙏

The main thing I didn't completely get is why we remove the prop className from all components Td, Th, Tr, but that we don't remove the usage of it? 🤔
Is it because we only want to use it internally, and not "publicly promote it"? 🤔

@tujoworker
Copy link
Member Author

The main thing I didn't completely get is why we remove the prop className from all components Td, Th, Tr, but that we don't remove the usage of it? 🤔 Is it because we only want to use it internally, and not "publicly promote it"? 🤔

Eufemia started with only table styles. But now that we have a component, we should go away from supporting "all features" with classes as well. This way we have less documentation to maintain.

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into my comments, I think I understand it all now 🧠 💪

@tujoworker tujoworker merged commit c40393a into main Nov 8, 2022
@tujoworker tujoworker deleted the feat/table-header-props branch November 8, 2022 13:32
tujoworker pushed a commit that referenced this pull request Nov 17, 2022
# [9.38.0-beta.1](v9.37.0...v9.38.0-beta.1) (2022-11-17)

### Bug Fixes

* add support to IS_SAFARI_DESKTOP for Safari v16 on macOS ([#1718](#1718)) ([54e2cba](54e2cba))
* **Anchor:** export types as AnchorAllProps and original instance ([#1715](#1715)) ([92ec784](92ec784))
* **Icons:** prevent icons from having same IDs (duplicate-id violation) ([#1714](#1714)) ([5e4079d](5e4079d))
* **Provider:** rewrite to functional component ([#1731](#1731)) ([b504d06](b504d06))
* **Table:** align odd/even modifiers with CSS nth ([#1724](#1724)) ([8bdad07](8bdad07))

### Features

* **Table:** add "fixed" prop for fixed table layouts ([#1708](#1708)) ([241ee0f](241ee0f))
* **Table:** add Table.SortButton ([#1709](#1709)) ([288a8db](288a8db))
* **Table:** add Th.HelpButton to be used in Table Headers ([#1711](#1711)) ([c142323](c142323))
* **Th:** add table header sortable props ([#1706](#1706)) ([c40393a](c40393a))
* **Tr:** automate odd/even and make it overridable ([#1705](#1705)) ([d73d3cb](d73d3cb))
* **Upload:** support files dropped on the document body ([#1719](#1719)) ([f206243](f206243))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 9.38.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

tujoworker pushed a commit that referenced this pull request Nov 22, 2022
# [9.38.0](v9.37.0...v9.38.0) (2022-11-22)

### Bug Fixes

* add support to IS_SAFARI_DESKTOP for Safari v16 on macOS ([#1718](#1718)) ([54e2cba](54e2cba))
* **Anchor:** export types as AnchorAllProps and original instance ([#1715](#1715)) ([92ec784](92ec784))
* **Icons:** prevent icons from having same IDs (duplicate-id violation) ([#1714](#1714)) ([5e4079d](5e4079d))
* **Provider:** rewrite to functional component ([#1731](#1731)) ([b504d06](b504d06))
* **Table:** align odd/even modifiers with CSS nth ([#1724](#1724)) ([8bdad07](8bdad07))

### Features

* **Table:** add "fixed" prop for fixed table layouts ([#1708](#1708)) ([241ee0f](241ee0f))
* **Table:** add table "border" and "outline" property ([#1739](#1739)) ([ad63ffb](ad63ffb))
* **Table:** add Table.ScrolView to support horizontal scroll ([#1735](#1735)) ([85a4d86](85a4d86))
* **Table:** add Table.SortButton ([#1709](#1709)) ([288a8db](288a8db))
* **Table:** add TableContainer to stack tables with an outline ([#1740](#1740)) ([376ac06](376ac06))
* **Table:** add Th.HelpButton to be used in Table Headers ([#1711](#1711)) ([c142323](c142323))
* **Table:** support rowSpan ([#1733](#1733)) ([463692d](463692d))
* **Th:** add table header sortable props ([#1706](#1706)) ([c40393a](c40393a))
* **Tr:** automate odd/even and make it overridable ([#1705](#1705)) ([d73d3cb](d73d3cb))
* **Typography:** support styles for superscript and subscript elements ([#1721](#1721)) ([c2b043d](c2b043d))
* **Upload:** support files dropped on the document body ([#1719](#1719)) ([f206243](f206243))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 9.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants