Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Drawer): ensure nav bar is aligned to left when content is wider than Drawer #1766

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

tujoworker
Copy link
Member

Before

Screenshot 2022-12-04 at 22 32 04

After

Screenshot 2022-12-04 at 22 34 29

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f1635d:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 4, 2022

✅ DNB Eufemia Portal deploy preview ready

@tujoworker tujoworker requested a review from langz December 5, 2022 06:21
@tujoworker tujoworker merged commit 533177d into main Dec 5, 2022
@tujoworker tujoworker deleted the fix/drawer-bar-left branch December 5, 2022 07:54
tujoworker pushed a commit that referenced this pull request Dec 6, 2022
# [9.40.0](v9.39.1...v9.40.0) (2022-12-06)

### Bug Fixes

*  deprecate `.dnb-not-sr-only` and `.dnb-sr-only--inline` ([#1755](#1755)) ([01a3e70](01a3e70))
* **Dialog:** align Dialog.Action to left when used in information variant ([#1761](#1761)) ([efd92d8](efd92d8))
* **Drawer:** ensure nav bar is aligned to left when content is wider than Drawer ([#1766](#1766)) ([533177d](533177d))
* **NumberFormat:** use `dnb-sr-only` instead of `dnb-sr-only--inline` ([#1754](#1754)) ([c49e516](c49e516))
* **Table:** enhance borders ([#1753](#1753)) ([3872c8e](3872c8e))
* **Table:** fix line-height of sorting buttons in smaller table sizes ([#1752](#1752)) ([97f0019](97f0019))
* **VisuallyHidden:** enhance space used on the underlying class .dnb-sr-only ([#1751](#1751)) ([11d6f33](11d6f33))

### Features

* **Table:** add row header style for scope="row" ([#1757](#1757)) ([34dd5c7](34dd5c7))
* **Table:** add sticky header support for overflow hidden on parent elements ([#1756](#1756)) ([48cd66b](48cd66b))
* **Th:** set scope by default to col and handle correct role ([#1764](#1764)) ([73613d6](73613d6))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 9.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants