Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Th): include by default aria-sort for assistive technology #1789

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

tujoworker
Copy link
Member

Add aria-sort to be handled by default. More info about aria-sort.

@tujoworker tujoworker requested a review from langz December 7, 2022 12:22
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4031db6:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 7, 2022

✅ DNB Eufemia Portal deploy preview ready

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I didn't know of this attribute 🥲

@tujoworker tujoworker merged commit 23f821b into main Dec 8, 2022
@tujoworker tujoworker deleted the feat/table-sort-aria-handling branch December 8, 2022 09:53
tujoworker pushed a commit that referenced this pull request Dec 12, 2022
# [9.41.0](v9.40.0...v9.41.0) (2022-12-12)

### Bug Fixes

* **FormLabel:** ensure sr_only prop will eliminate label height ([#1798](#1798)) ([e79057e](e79057e))
* **InputPassword:** hide password reveal in Edge ([#1794](#1794)) ([1fcc541](1fcc541))
* **scrollToLocationHashId:** omit calling scrollTo when element is not found ([#1796](#1796)) ([cb497de](cb497de))
* **Table:** fix odd/even re-oder and StrictMode support ([#1797](#1797)) ([d7804f0](d7804f0))
* **Table:** make Table.ScrollView accessible with keyboard navigation ([#1801](#1801)) ([0239978](0239978))

### Features

* **ScrollView:** add `interactive` prop to support for keyboard control (accessible) ([#1791](#1791)) ([e265e4a](e265e4a))
* **Table:** add accordion feature to table rows ([#1737](#1737)) ([fe41e55](fe41e55))
* **Th:** include by default aria-sort for assistive technology ([#1789](#1789)) ([23f821b](23f821b))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 9.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants