Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormLabel): ensure sr_only prop will eliminate label height #1798

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

tujoworker
Copy link
Member

Before
Screenshot 2022-12-10 at 16 07 42

After
Screenshot 2022-12-10 at 16 08 36

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d019a9e:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 10, 2022

✅ DNB Eufemia Portal deploy preview ready

@tujoworker tujoworker requested a review from langz December 12, 2022 06:54
@tujoworker tujoworker merged commit e79057e into main Dec 12, 2022
@tujoworker tujoworker deleted the fix/form-label-sr-only branch December 12, 2022 09:08
tujoworker pushed a commit that referenced this pull request Dec 12, 2022
# [9.41.0](v9.40.0...v9.41.0) (2022-12-12)

### Bug Fixes

* **FormLabel:** ensure sr_only prop will eliminate label height ([#1798](#1798)) ([e79057e](e79057e))
* **InputPassword:** hide password reveal in Edge ([#1794](#1794)) ([1fcc541](1fcc541))
* **scrollToLocationHashId:** omit calling scrollTo when element is not found ([#1796](#1796)) ([cb497de](cb497de))
* **Table:** fix odd/even re-oder and StrictMode support ([#1797](#1797)) ([d7804f0](d7804f0))
* **Table:** make Table.ScrollView accessible with keyboard navigation ([#1801](#1801)) ([0239978](0239978))

### Features

* **ScrollView:** add `interactive` prop to support for keyboard control (accessible) ([#1791](#1791)) ([e265e4a](e265e4a))
* **Table:** add accordion feature to table rows ([#1737](#1737)) ([fe41e55](fe41e55))
* **Th:** include by default aria-sort for assistive technology ([#1789](#1789)) ([23f821b](23f821b))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 9.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

joakbjerk pushed a commit that referenced this pull request Mar 27, 2023
* fix(FormLabel): ensure sr_only prop will eliminate label height

* Update snapshots

Co-authored-by: Tobias Høegh <tobias.hoegh@dnb.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants