Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): make sticky header work when used in combination with accordion rows #1835

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Dec 19, 2022

Reported bug.

👉Before
Screenshot 2022-12-19 at 20 20 13

👉After
Screenshot 2022-12-19 at 21 30 10

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 19, 2022

✅ DNB Eufemia Portal deploy preview ready

@tujoworker tujoworker force-pushed the fix/table-accordion-sticky-header branch from d884d2d to 94bad12 Compare December 20, 2022 05:21
@tujoworker tujoworker force-pushed the fix/table-accordion-sticky-header branch from 94bad12 to 267d9ea Compare December 20, 2022 05:22
@tujoworker tujoworker requested a review from langz December 20, 2022 05:24
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 267d9ea:

Sandbox Source
eufemia-starter Configuration

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tujoworker tujoworker merged commit dec1ddb into main Dec 20, 2022
@tujoworker tujoworker deleted the fix/table-accordion-sticky-header branch December 20, 2022 07:04
tujoworker pushed a commit that referenced this pull request Dec 20, 2022
# [9.44.0](v9.43.0...v9.44.0) (2022-12-20)

### Bug Fixes

* **Table:** inherit Tr noWrap to Th.SortButton ([#1836](#1836)) ([0ce4763](0ce4763))
* **Table:** make sticky header work when used in combination with accordion rows ([#1835](#1835)) ([dec1ddb](dec1ddb))

### Features

* **Table:** add accordion row events ([#1834](#1834)) ([c7be834](c7be834))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 9.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants