-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Upload): fix handling of file types in combination with file extension #1986
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84a3045:
|
✅ DNB Eufemia Portal deploy preview ready
|
Gave it a quick test, and found out that if Not sure if this is intended or not, but it's at least an observation/diff from existing functionality deployed to https://eufemia.dnb.no/ |
packages/dnb-eufemia/src/components/upload/UploadFileListCell.tsx
Outdated
Show resolved
Hide resolved
packages/dnb-eufemia/src/components/upload/__tests__/UploadFileListCell.test.tsx
Outdated
Show resolved
Hide resolved
packages/dnb-eufemia/src/components/upload/UploadFileListCell.tsx
Outdated
Show resolved
Hide resolved
packages/dnb-eufemia/src/components/upload/UploadFileListCell.tsx
Outdated
Show resolved
Hide resolved
The diff is, now, when a slash is given, we do not add a dot. Before we added a dot, even if |
0ef1805
to
5d37d61
Compare
5d37d61
to
84a3045
Compare
## [9.47.1](v9.47.0...v9.47.1) (2023-02-13) ### Bug Fixes * **InputMasked:** avoid inherit mask options and types when custom mask is used ([#1988](#1988)) ([8937bcc](8937bcc)) * **InputMasked:** fix negative value updates (number mask) ([#1792](#1792)) ([e2b9482](e2b9482)) * **Upload:** fix handling of file types in combination with file extension ([#1986](#1986)) ([3fd9bfa](3fd9bfa))
🎉 This PR is included in version 9.47.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR is based on #1824
Before, we did mix file extension and file mime type:
Now it uses what ever is defined in the
acceptedFileTypes={['txt']}
:Now it uses what ever is defined in the
acceptedFileTypes={['text/plain']}
: