fix(Tabs): fix error with a single Tabs.Content as children #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 07e7443:
|
langz
force-pushed
the
fix/tabs-single-react-element-as-children
branch
from
5c7c41f to
4d4c286
Compare
langz
changed the title
langz
changed the title
langz
commented
Jul 27, 2023
packages/dnb-eufemia/src/components/tabs/__tests__/Tabs.screenshot.test.ts
Outdated
Show resolved
Hide resolved
langz
commented
Jul 27, 2023
packages/dnb-eufemia/src/components/tabs/__tests__/Tabs.screenshot.test.ts
Outdated
Show resolved
Hide resolved
langz
commented
Jul 27, 2023
tujoworker
pushed a commit
that referenced
this pull request
Jul 27, 2023
## [10.4.2](v10.4.1...v10.4.2) (2023-07-27) ### 🐛 Bug Fixes * **Tabs:** fix error with a single Tabs.Content as children ([#2534](#2534)) ([215e52c](215e52c))
|
🎉 This PR is included in version 10.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should:
childrendataprop has a single element and when Tabs component has a single Tabs.content aschildren.Here's how it looked and behaved when providing Tabs component with a single Tabs.Content as children:
And when pressing the Tabs title you would get:
Now after the fix, the same code will not result in an error, and it will look like this: