Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Field.Toggle): removes invisible label when label not provided #3984

Merged
merged 6 commits into from
Sep 24, 2024
Merged

fix(Field.Toggle): removes invisible label when label not provided #3984

merged 6 commits into from
Sep 24, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Sep 23, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 10:19am

langz
langz commented Sep 23, 2024
View reviewed changes
packages/dnb-design-system-portal/src/docs/uilib/extensions/forms/base-fields/Toggle/demos.mdx Outdated
@@ -66,6 +66,12 @@ import * as Examples from './Examples'

<Examples.VariantButtonsWithHelp />

#### Buttons without label
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Buttons without label

@langz langz changed the title fix(Field.Toggle): removes invisible label when not provided fix(Field.Toggle): removes invisible label when label not provided Sep 23, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Sep 23, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz force-pushed the fix/invisible-label-field-toggle-variant-buttons branch from ba67ae8 to b397511 Compare September 23, 2024 12:43
tujoworker
tujoworker approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather move the logic into the FieldBlock itself. Because other fields may suffer from the same. I pushed a commit with tests.

I could not find any isFragment or fragmentHasChildren, so added for now to the FieldBlock.

@langz
Copy link
Contributor Author

langz commented Sep 24, 2024

I would rather move the logic into the FieldBlock itself. Because other fields may suffer from the same. I pushed a commit with tests.

I could not find any isFragment or fragmentHasChildren, so added for now to the FieldBlock.

Great, thanks.
I see that the existing fix does not work anymore now, I'll look into it.
Now it looks like this(as it did before the fix):
image

@langz
Copy link
Contributor Author

langz commented Sep 24, 2024

I would rather move the logic into the FieldBlock itself. Because other fields may suffer from the same. I pushed a commit with tests.
I could not find any isFragment or fragmentHasChildren, so added for now to the FieldBlock.

Great, thanks. I see that the existing fix does not work anymore now, I'll look into it. Now it looks like this(as it did before the fix): image

I've added a fix for this now, in the following commit 7fa80f5

Happy with how the fix looks now 🙏

@langz
Copy link
Contributor Author

langz commented Sep 24, 2024 •
edited
Loading

I also had to update screenshot tests in ArraySelection, in this commit 68370f6

Looks good to me:
image

@langz
Copy link
Contributor Author

langz commented Sep 24, 2024 •
edited
Loading

Hmm, seems like I have to update more screenshot tests for ArraySelection 63e535a and 045ec2a

@langz langz merged commit c945d5b into main Sep 24, 2024
10 checks passed
@langz langz deleted the fix/invisible-label-field-toggle-variant-buttons branch September 24, 2024 11:04
tujoworker pushed a commit that referenced this pull request Sep 30, 2024
@semantic-release-bot
chore(release): 10.51.0 [skip ci]
311692c 
## [10.51.0](v10.50.0...v10.51.0) (2024-09-30)

### 🐛 Bug Fixes

* **Field.Toggle:** removes invisible label when label not provided ([#3984](#3984)) ([c945d5b](c945d5b))
* **Forms:** `Form.useData` should not throw error when used in Wizard ([#4001](#4001)) ([aac721b](aac721b))
* **Forms:** ensure `itemNr` still works in the Iterate.ViewContainer ([#4002](#4002)) ([6f8bfb3](6f8bfb3))
* **Forms:** keep field state during a Wizard step change when used inside Iterate.Array (which used defualtValue as the data source) ([#4025](#4025)) ([595cfd5](595cfd5))
* **Forms:** removes cards max-width in Wizard (StepIndicator) ([#4011](#4011)) ([2bc8812](2bc8812))
* **Tabs:** fix align property with value center ([#3991](#3991)) ([8483df8](8483df8))

### ✨ Features

* **ChildrenWithAge:** display hasChildren value in summary ([#3993](#3993)) ([9ab9de5](9ab9de5))
* **Field.Date:** add date range functionality ([#4006](#4006)) ([12081c3](12081c3))
* **Forms:** add `Form.SubmitConfirmation` to confirm a submit during or before sent ([#4019](#4019)) ([dfce4e4](dfce4e4))
* **Forms:** add `inheritVisibility` to Value.SummaryList ([#4003](#4003)) ([9849516](9849516))
* **Forms:** add inheritLabel to Value.SummaryList ([#4009](#4009)) ([1715a6a](1715a6a))
* **Forms:** add Value.Provider to propagate value props down to Value.* components (e.g. `inheritVisibility`) ([#4005](#4005)) ([c3f10e3](c3f10e3)), closes [#4003](#4003)
* **Forms:** deprecate `Form.FieldProps` in favor of `Field.Provider` ([#4020](#4020)) ([d549870](d549870))
* **Forms:** deprecate Form.useError in favor of `Form.useValidation` featuring `setFieldStatus` to handle the status (error) of a single field ([#3986](#3986)) ([dd39eef](dd39eef))
* **Forms:** implement TypeScript version of `json-pointer` ([#4000](#4000)) ([f3caa4b](f3caa4b))
* **NumberFormat:** add `half-even` rounding and deprecated `omit_rounding` in favor of `rounding="omit"` ([#3988](#3988)) ([0c121f1](0c121f1))
* **SASS mixins:** media queries mixins now uses 0.1px instead of 1px to avoid overlap ([#3985](#3985)) ([1cb495a](1cb495a)), closes [media#sect2](https://github.com/dnbexperience/media/issues/sect2)
* **Switch:** refactor to typescript ([#3727](#3727)) ([4833c42](4833c42))

### 📝 Documentation

* adds import statement to info doc for layout ([#4018](#4018)) ([0508c4b](0508c4b))
* **Forms:** improves docs for Value.Number & Value.Currency ([#4008](#4008)) ([cc1c365](cc1c365))
* **Portal:** add accordion to side menu ([#3794](#3794)) ([e2604f6](e2604f6))
* prop -> property, and props -> properties ([#3990](#3990)) ([a122fa2](a122fa2))
* **Value.Currency:** improve documented properties ([#4022](#4022)) ([d392901](d392901)), closes [/github.com//pull/4008#discussion_r1776864819](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/pull/4008/issues/discussion_r1776864819)
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.51.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakbjerk joakbjerk joakbjerk approved these changes

@tujoworker tujoworker tujoworker approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@langz @tujoworker @joakbjerk