-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NumberFormat): add half-even
rounding and deprecated omit_rounding
in favor of rounding="omit"
#3988
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
omit_rounding
in favor of rounding="omit"half-even
roudning and deprecated omit_rounding
in favor of rounding="omit"
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
half-even
roudning and deprecated omit_rounding
in favor of rounding="omit"
half-even
rounding and deprecated omit_rounding
in favor of rounding="omit"
34048c9
to
80723ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner! ⭐️
packages/dnb-design-system-portal/src/docs/uilib/components/number-format/info.mdx
Outdated
Show resolved
Hide resolved
packages/dnb-eufemia/src/components/number-format/NumberFormat.d.ts
Outdated
Show resolved
Hide resolved
packages/dnb-eufemia/src/components/number-format/NumberFormatDocs.ts
Outdated
Show resolved
Hide resolved
packages/dnb-eufemia/src/components/number-format/NumberUtils.d.ts
Outdated
Show resolved
Hide resolved
packages/dnb-eufemia/src/components/number-format/NumberUtils.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
Co-authored-by: Joakim Bjerknes <joakbjerk@gmail.com>
packages/dnb-eufemia/src/components/number-format/NumberFormatDocs.ts
Outdated
Show resolved
Hide resolved
…Docs.ts Co-authored-by: Anders <anderslangseth@gmail.com>
## [10.51.0](v10.50.0...v10.51.0) (2024-09-30) ### 🐛 Bug Fixes * **Field.Toggle:** removes invisible label when label not provided ([#3984](#3984)) ([c945d5b](c945d5b)) * **Forms:** `Form.useData` should not throw error when used in Wizard ([#4001](#4001)) ([aac721b](aac721b)) * **Forms:** ensure `itemNr` still works in the Iterate.ViewContainer ([#4002](#4002)) ([6f8bfb3](6f8bfb3)) * **Forms:** keep field state during a Wizard step change when used inside Iterate.Array (which used defualtValue as the data source) ([#4025](#4025)) ([595cfd5](595cfd5)) * **Forms:** removes cards max-width in Wizard (StepIndicator) ([#4011](#4011)) ([2bc8812](2bc8812)) * **Tabs:** fix align property with value center ([#3991](#3991)) ([8483df8](8483df8)) ### ✨ Features * **ChildrenWithAge:** display hasChildren value in summary ([#3993](#3993)) ([9ab9de5](9ab9de5)) * **Field.Date:** add date range functionality ([#4006](#4006)) ([12081c3](12081c3)) * **Forms:** add `Form.SubmitConfirmation` to confirm a submit during or before sent ([#4019](#4019)) ([dfce4e4](dfce4e4)) * **Forms:** add `inheritVisibility` to Value.SummaryList ([#4003](#4003)) ([9849516](9849516)) * **Forms:** add inheritLabel to Value.SummaryList ([#4009](#4009)) ([1715a6a](1715a6a)) * **Forms:** add Value.Provider to propagate value props down to Value.* components (e.g. `inheritVisibility`) ([#4005](#4005)) ([c3f10e3](c3f10e3)), closes [#4003](#4003) * **Forms:** deprecate `Form.FieldProps` in favor of `Field.Provider` ([#4020](#4020)) ([d549870](d549870)) * **Forms:** deprecate Form.useError in favor of `Form.useValidation` featuring `setFieldStatus` to handle the status (error) of a single field ([#3986](#3986)) ([dd39eef](dd39eef)) * **Forms:** implement TypeScript version of `json-pointer` ([#4000](#4000)) ([f3caa4b](f3caa4b)) * **NumberFormat:** add `half-even` rounding and deprecated `omit_rounding` in favor of `rounding="omit"` ([#3988](#3988)) ([0c121f1](0c121f1)) * **SASS mixins:** media queries mixins now uses 0.1px instead of 1px to avoid overlap ([#3985](#3985)) ([1cb495a](1cb495a)), closes [media#sect2](https://github.com/dnbexperience/media/issues/sect2) * **Switch:** refactor to typescript ([#3727](#3727)) ([4833c42](4833c42)) ### 📝 Documentation * adds import statement to info doc for layout ([#4018](#4018)) ([0508c4b](0508c4b)) * **Forms:** improves docs for Value.Number & Value.Currency ([#4008](#4008)) ([cc1c365](cc1c365)) * **Portal:** add accordion to side menu ([#3794](#3794)) ([e2604f6](e2604f6)) * prop -> property, and props -> properties ([#3990](#3990)) ([a122fa2](a122fa2)) * **Value.Currency:** improve documented properties ([#4022](#4022)) ([d392901](d392901)), closes [/github.com//pull/4008#discussion_r1776864819](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/pull/4008/issues/discussion_r1776864819)
🎉 This PR is included in version 10.51.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We need a following up PR to add support to the Value.Number and Value.Currency components.