docs(Forms): improves docs for Value.Number & Value.Currency #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
langz
force-pushed
the
chore/improve-currency-docs
branch
from
c5fbef0 to
5a65c97
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
force-pushed
the
chore/improve-currency-docs
branch
from
5a65c97 to
e35f92a
Compare
tujoworker
approved these changes
Sep 26, 2024
1 task
langz
added a commit
that referenced
this pull request
Sep 30, 2024
tujoworker
added a commit
that referenced
this pull request
Sep 30, 2024
Follow-up to #4008 (comment) As of now docs looks like the following([deploy preview](https://eufemia-dnb-design-system-portal.vercel.app/uilib/extensions/forms/Value/Currency/properties/) of release [v10.51](#4012)): This PR will change it to be looking like this([deploy preview](https://eufemia-git-docs-improve-value-currency-docs-eufemia.vercel.app/uilib/extensions/forms/Value/Currency/properties/) this PR). TODO: - [x] Decide which props we want to display under [Value-specific properties](https://eufemia-git-docs-improve-value-currency-docs-eufemia.vercel.app/uilib/extensions/forms/Value/Currency/properties/#value-specific-properties) --------- Co-authored-by: Tobias Høegh <tobias@tujo.no>
tujoworker
pushed a commit
that referenced
this pull request
Sep 30, 2024
## [10.51.0](v10.50.0...v10.51.0) (2024-09-30) ### 🐛 Bug Fixes * **Field.Toggle:** removes invisible label when label not provided ([#3984](#3984)) ([c945d5b](c945d5b)) * **Forms:** `Form.useData` should not throw error when used in Wizard ([#4001](#4001)) ([aac721b](aac721b)) * **Forms:** ensure `itemNr` still works in the Iterate.ViewContainer ([#4002](#4002)) ([6f8bfb3](6f8bfb3)) * **Forms:** keep field state during a Wizard step change when used inside Iterate.Array (which used defualtValue as the data source) ([#4025](#4025)) ([595cfd5](595cfd5)) * **Forms:** removes cards max-width in Wizard (StepIndicator) ([#4011](#4011)) ([2bc8812](2bc8812)) * **Tabs:** fix align property with value center ([#3991](#3991)) ([8483df8](8483df8)) ### ✨ Features * **ChildrenWithAge:** display hasChildren value in summary ([#3993](#3993)) ([9ab9de5](9ab9de5)) * **Field.Date:** add date range functionality ([#4006](#4006)) ([12081c3](12081c3)) * **Forms:** add `Form.SubmitConfirmation` to confirm a submit during or before sent ([#4019](#4019)) ([dfce4e4](dfce4e4)) * **Forms:** add `inheritVisibility` to Value.SummaryList ([#4003](#4003)) ([9849516](9849516)) * **Forms:** add inheritLabel to Value.SummaryList ([#4009](#4009)) ([1715a6a](1715a6a)) * **Forms:** add Value.Provider to propagate value props down to Value.* components (e.g. `inheritVisibility`) ([#4005](#4005)) ([c3f10e3](c3f10e3)), closes [#4003](#4003) * **Forms:** deprecate `Form.FieldProps` in favor of `Field.Provider` ([#4020](#4020)) ([d549870](d549870)) * **Forms:** deprecate Form.useError in favor of `Form.useValidation` featuring `setFieldStatus` to handle the status (error) of a single field ([#3986](#3986)) ([dd39eef](dd39eef)) * **Forms:** implement TypeScript version of `json-pointer` ([#4000](#4000)) ([f3caa4b](f3caa4b)) * **NumberFormat:** add `half-even` rounding and deprecated `omit_rounding` in favor of `rounding="omit"` ([#3988](#3988)) ([0c121f1](0c121f1)) * **SASS mixins:** media queries mixins now uses 0.1px instead of 1px to avoid overlap ([#3985](#3985)) ([1cb495a](1cb495a)), closes [media#sect2](https://github.com/dnbexperience/media/issues/sect2) * **Switch:** refactor to typescript ([#3727](#3727)) ([4833c42](4833c42)) ### 📝 Documentation * adds import statement to info doc for layout ([#4018](#4018)) ([0508c4b](0508c4b)) * **Forms:** improves docs for Value.Number & Value.Currency ([#4008](#4008)) ([cc1c365](cc1c365)) * **Portal:** add accordion to side menu ([#3794](#3794)) ([e2604f6](e2604f6)) * prop -> property, and props -> properties ([#3990](#3990)) ([a122fa2](a122fa2)) * **Value.Currency:** improve documented properties ([#4022](#4022)) ([d392901](d392901)), closes [/github.com//pull/4008#discussion_r1776864819](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/pull/4008/issues/discussion_r1776864819)
|
🎉 This PR is included in version 10.51.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be demoed here: