Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Forms): add Form.SubmitConfirmation to confirm a submit during or before sent #4019

Merged
merged 4 commits into from
Sep 29, 2024
Merged

feat(Forms): add Form.SubmitConfirmation to confirm a submit during or before sent #4019

merged 4 commits into from
Sep 29, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Sep 27, 2024 •
edited
Loading

Quick example:

<Form.Handler
  onSubmit={async () => {
    // Your submit request
  }}
>
  Content...
  <Form.SubmitButton />
  <Form.SubmitConfirmation
    renderWithState={({ connectWithDialog }) => {
      return (
        <>
          {content}
          <Dialog
            variant="confirmation"
            title="Dialog confirmation title"
            description="Some content describing the situation."
            {...connectWithDialog}
          />
        </>
      )
    }}
  />
</Form.Handler>

@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 8:58am

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Sep 27, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker changed the title feat(Forms): add Form.Confirm to confirm a submit before sent feat(Forms): add Form.SubmitConfirmation to confirm a submit before sent Sep 27, 2024
@tujoworker tujoworker force-pushed the feat/form-submit-confirmation branch 2 times, most recently from 419b664 to ba11231 Compare September 27, 2024 10:05
@tujoworker tujoworker force-pushed the feat/form-submit-confirmation branch 2 times, most recently from f46f4ef to fb8f9e5 Compare September 27, 2024 11:09
@tujoworker tujoworker force-pushed the feat/form-submit-confirmation branch 4 times, most recently from 2aec09a to 104948d Compare September 27, 2024 15:13
@tujoworker tujoworker force-pushed the feat/form-submit-confirmation branch from 3a60b51 to 10b5cde Compare September 27, 2024 20:53
tujoworker and others added 2 commits September 27, 2024 22:56
@tujoworker @langz
feat(Forms): add Form.Confirm to confirm a submit before sent
374ef13 
Co-authored-by: Anders <anderslangseth@gmail.com>
@tujoworker @langz
Add preventSubmitWhen to be opt-in
366da56 
Co-authored-by: Anders <anderslangseth@gmail.com>
@tujoworker tujoworker changed the title feat(Forms): add Form.SubmitConfirmation to confirm a submit before sent feat(Forms): add Form.SubmitConfirmation to confirm a submit during or before sent Sep 28, 2024
@tujoworker tujoworker force-pushed the feat/form-submit-confirmation branch from 8ea55de to 249fbd6 Compare September 28, 2024 08:42
@tujoworker tujoworker force-pushed the feat/form-submit-confirmation branch from 249fbd6 to 405da40 Compare September 28, 2024 08:43
@tujoworker tujoworker merged commit dfce4e4 into main Sep 29, 2024
10 checks passed
@tujoworker tujoworker deleted the feat/form-submit-confirmation branch September 29, 2024 19:08
langz pushed a commit that referenced this pull request Sep 30, 2024
@tujoworker @langz
feat(Forms): add Form.SubmitConfirmation to confirm a submit during…
b947c47 
… or before sent (#4019)
tujoworker pushed a commit that referenced this pull request Sep 30, 2024
@semantic-release-bot
chore(release): 10.51.0 [skip ci]
311692c 
## [10.51.0](v10.50.0...v10.51.0) (2024-09-30)

### 🐛 Bug Fixes

* **Field.Toggle:** removes invisible label when label not provided ([#3984](#3984)) ([c945d5b](c945d5b))
* **Forms:** `Form.useData` should not throw error when used in Wizard ([#4001](#4001)) ([aac721b](aac721b))
* **Forms:** ensure `itemNr` still works in the Iterate.ViewContainer ([#4002](#4002)) ([6f8bfb3](6f8bfb3))
* **Forms:** keep field state during a Wizard step change when used inside Iterate.Array (which used defualtValue as the data source) ([#4025](#4025)) ([595cfd5](595cfd5))
* **Forms:** removes cards max-width in Wizard (StepIndicator) ([#4011](#4011)) ([2bc8812](2bc8812))
* **Tabs:** fix align property with value center ([#3991](#3991)) ([8483df8](8483df8))

### ✨ Features

* **ChildrenWithAge:** display hasChildren value in summary ([#3993](#3993)) ([9ab9de5](9ab9de5))
* **Field.Date:** add date range functionality ([#4006](#4006)) ([12081c3](12081c3))
* **Forms:** add `Form.SubmitConfirmation` to confirm a submit during or before sent ([#4019](#4019)) ([dfce4e4](dfce4e4))
* **Forms:** add `inheritVisibility` to Value.SummaryList ([#4003](#4003)) ([9849516](9849516))
* **Forms:** add inheritLabel to Value.SummaryList ([#4009](#4009)) ([1715a6a](1715a6a))
* **Forms:** add Value.Provider to propagate value props down to Value.* components (e.g. `inheritVisibility`) ([#4005](#4005)) ([c3f10e3](c3f10e3)), closes [#4003](#4003)
* **Forms:** deprecate `Form.FieldProps` in favor of `Field.Provider` ([#4020](#4020)) ([d549870](d549870))
* **Forms:** deprecate Form.useError in favor of `Form.useValidation` featuring `setFieldStatus` to handle the status (error) of a single field ([#3986](#3986)) ([dd39eef](dd39eef))
* **Forms:** implement TypeScript version of `json-pointer` ([#4000](#4000)) ([f3caa4b](f3caa4b))
* **NumberFormat:** add `half-even` rounding and deprecated `omit_rounding` in favor of `rounding="omit"` ([#3988](#3988)) ([0c121f1](0c121f1))
* **SASS mixins:** media queries mixins now uses 0.1px instead of 1px to avoid overlap ([#3985](#3985)) ([1cb495a](1cb495a)), closes [media#sect2](https://github.com/dnbexperience/media/issues/sect2)
* **Switch:** refactor to typescript ([#3727](#3727)) ([4833c42](4833c42))

### 📝 Documentation

* adds import statement to info doc for layout ([#4018](#4018)) ([0508c4b](0508c4b))
* **Forms:** improves docs for Value.Number & Value.Currency ([#4008](#4008)) ([cc1c365](cc1c365))
* **Portal:** add accordion to side menu ([#3794](#3794)) ([e2604f6](e2604f6))
* prop -> property, and props -> properties ([#3990](#3990)) ([a122fa2](a122fa2))
* **Value.Currency:** improve documented properties ([#4022](#4022)) ([d392901](d392901)), closes [/github.com//pull/4008#discussion_r1776864819](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/pull/4008/issues/discussion_r1776864819)
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.51.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tujoworker @langz