Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Field.Selection): prevent radio re-render onClick to enable keyboard navigation #4037

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Oct 1, 2024

closes this issue

Before:

Screen.Recording.2024-10-01.at.10.21.12.mov

After:

Screen.Recording.2024-10-01.at.10.20.24.mov

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 10:22am

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧗‍♂️

Copy link

codesandbox-ci bot commented Oct 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you add a test too?

@joakbjerk
Copy link
Contributor Author

Nice! Can you add a test too?

Of course 👍

@langz langz changed the title fix(Field.Selection): prevent radio re-render onClick to enable keyboard naviation fix(Field.Selection): prevent radio re-render onClick to enable keyboard navigation Oct 1, 2024
@langz langz merged commit d122f98 into main Oct 1, 2024
10 checks passed
@langz langz deleted the fix/selection-radio-option-keyboard-navigation branch October 1, 2024 12:49
tujoworker pushed a commit that referenced this pull request Oct 3, 2024
## [10.51.2](v10.51.1...v10.51.2) (2024-10-03)

### 🐛 Bug Fixes

* **Badge:** prevents unwanted re-rendering ([#4049](#4049)) ([1e51e7a](1e51e7a))
* **Field.Selection:** prevent `radio` re-render onClick to enable keyboard navigation ([#4037](#4037)) ([d122f98](d122f98))
* **Forms:** support validation when using object based `transformOut` and `transformIn` on fields ([#4042](#4042)) ([5554525](5554525)), closes [#3997](#3997)
* **Timeline:** alt label complete -> completed ([#4044](#4044)) ([4a6828d](4a6828d))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.51.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

bug(Field.Selection): keyboard navigation in variant radio
3 participants