-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Field.Selection): prevent radio
re-render onClick to enable keyboard navigation
#4037
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧗♂️
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Can you add a test too?
Of course 👍 |
radio
re-render onClick to enable keyboard naviationradio
re-render onClick to enable keyboard navigation
## [10.51.2](v10.51.1...v10.51.2) (2024-10-03) ### 🐛 Bug Fixes * **Badge:** prevents unwanted re-rendering ([#4049](#4049)) ([1e51e7a](1e51e7a)) * **Field.Selection:** prevent `radio` re-render onClick to enable keyboard navigation ([#4037](#4037)) ([d122f98](d122f98)) * **Forms:** support validation when using object based `transformOut` and `transformIn` on fields ([#4042](#4042)) ([5554525](5554525)), closes [#3997](#3997) * **Timeline:** alt label complete -> completed ([#4044](#4044)) ([4a6828d](4a6828d))
🎉 This PR is included in version 10.51.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes this issue
Before:
Screen.Recording.2024-10-01.at.10.21.12.mov
After:
Screen.Recording.2024-10-01.at.10.20.24.mov