Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Forms): ensure Field.Upload handles required logic between Wizard step changes #4248

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Nov 8, 2024

More info here.

Thank you Anders for good reprod 💯

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 8:55am

Copy link

codesandbox-ci bot commented Nov 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️💚❤️

Any other fields where the same could happen? Or is this Field a bit unique in that sense?

❤️💚❤️

@tujoworker
Copy link
Member Author

It has it's own required logic. The check/if statement needed to be more precise.

@tujoworker
Copy link
Member Author

I will rewrite the tests a bit before merging.

@tujoworker tujoworker force-pushed the fix/upload-in-wizard branch from b473af3 to 7b0102d Compare November 9, 2024 08:46
@tujoworker tujoworker merged commit 505dbc1 into main Nov 9, 2024
10 checks passed
@tujoworker tujoworker deleted the fix/upload-in-wizard branch November 9, 2024 09:33
tujoworker pushed a commit that referenced this pull request Nov 11, 2024
## [10.55.1](v10.55.0...v10.55.1) (2024-11-11)

### 🐛 Bug Fixes

* **Forms:** console log a warning when Value.SummaryList gets an invalid child ([#4249](#4249)) ([011e9eb](011e9eb))
* **Forms:** ensure Field.Upload handles `required` logic between Wizard step changes ([#4248](#4248)) ([505dbc1](505dbc1))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.55.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants