fix(Forms): console log a warning when Value.SummaryList gets an invalid child #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
force-pushed
the
fix/summary-list-warning
branch
from
3618c4f to
aa6d2fc
Compare
langz
approved these changes
Nov 9, 2024
packages/dnb-eufemia/src/extensions/forms/Value/SummaryList/useVerifyChildren.ts
Show resolved
Hide resolved
| } from 'react' | ||
| import { warn } from '../../../../shared/helpers' | ||
|
|
||
| export function useVerifyChildren({ |
There was a problem hiding this comment.
When reading verifyChildren.
I immediately think that it verifies children, but what does it mean to verify children?🤔
Some other potential names:
- useVerifyChildrenNotEmpty
- useVerifyChildrenHasElements
- useChildrenNotEmpty
- useVerifyChildrenHasItems
- useVerifyChildrenHasChildren
There was a problem hiding this comment.
It's more understandable now when we've added a PR description🥳🫡
tujoworker
force-pushed
the
fix/summary-list-warning
branch
from
aa6d2fc to
f087e63
Compare
tujoworker
pushed a commit
that referenced
this pull request
Nov 11, 2024
## [10.55.1](v10.55.0...v10.55.1) (2024-11-11) ### 🐛 Bug Fixes * **Forms:** console log a warning when Value.SummaryList gets an invalid child ([#4249](#4249)) ([011e9eb](011e9eb)) * **Forms:** ensure Field.Upload handles `required` logic between Wizard step changes ([#4248](#4248)) ([505dbc1](505dbc1))
|
🎉 This PR is included in version 10.55.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info here.
It verifies that only allowed children are passed.
It does this by comparing the amount of given children components vs the amount of the actual wanted components (verified via a context call).⚠️
When there are more other children than the wanted ones, we show a warning
I'm not sure if there are smarter ways to do that. But as of now, I think this may work.