fix(Upload): display files without anchor when their size is not given #4390
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
force-pushed
the
fix/forms-upload-empty-file
branch
4 times, most recently
from
1dc796f to
5eee87b
Compare
|
|
||
| ### Display files as non-clickable | ||
|
|
||
| When file size is 0, the file is displayed as a span instead of an anchor. |
There was a problem hiding this comment.
Why?
Because there's no file if file size is 0?
There was a problem hiding this comment.
new File([], name, { type }) will create a file with the size 0 when downloading it. But a file with the size of 0 is not valid. So then we "show" just the name, but do now allow it to be downloaded or displayed.
There was a problem hiding this comment.
Makes sense. We could perhaps state this reason in the docs as well🤌
There was a problem hiding this comment.
And perhaps something about that if providing onFileClick, it will display a button no matter what the file size is.
tujoworker
force-pushed
the
fix/forms-upload-empty-file
branch
from
5eee87b to
9fe925d
Compare
tujoworker
force-pushed
the
fix/forms-upload-empty-file
branch
from
9fe925d to
d994fad
Compare
langz
force-pushed
the
fix/forms-upload-empty-file
branch
from
d994fad to
02b453d
Compare
|
I rebased this with latest main now. |
## [10.61.0](v10.60.1...v10.61.0) (2024-12-13) ### 📝 Documentation * add guidelines for writing commit messages to the contribution guide ([#4389](#4389)) ([34eff0e](34eff0e)) * **Upload:** add `id` property ([#4401](#4401)) ([56d4956](56d4956)) ### ✨ Features * **Forms:** add missing support for `defaultValue` for Field.Slider ([#4394](#4394)) ([701ab66](701ab66)) * **Logo:** update sbanken logo ([#4379](#4379)) ([069ae1a](069ae1a)) * **Upload:** make `id` property as optional ([#4405](#4405)) ([0c58973](0c58973)) * **Value.Upload:** add async `onFileClick` event ([#4397](#4397)) ([be1c21c](be1c21c)) ### 🐛 Bug Fixes * **DatePicker:** add `null` as possible date type as return value ([#4407](#4407)) ([363e0b5](363e0b5)) * **DatePicker:** throw error when `date` is invalid ([#4396](#4396)) ([f977ebc](f977ebc)) * **FieldBlock:** remove max-width for label when width stretch ([#4406](#4406)) ([20c02d4](20c02d4)) * **Forms:** enhance transformIn and transformOut to support changed array and object instances ([#4392](#4392)) ([ae4648a](ae4648a)), closes [#4366](#4366) * **Slider:** ensure `min` and `max` value is respected when `step` doesn't fit exactly ([#4395](#4395)) ([2c00b0c](2c00b0c)) * **Tabs:** ensure cached content never takes up visual space ([#4399](#4399)) ([360aacc](360aacc)) * **Upload:** display files without anchor when their size is not given ([#4390](#4390)) ([70df7c8](70df7c8)) * **Upload:** display spinner in async `onFileClick` without file `id` ([#4393](#4393)) ([b743d6e](b743d6e))
|
🎉 This PR is included in version 10.61.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Example for Value.Upload(https://eufemia-git-fix-forms-upload-empty-file-eufemia.vercel.app//uilib/extensions/forms/Value/Upload/#display-files-as-non-clickable)