-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FieldBlock): remove max-width for label when width stretch #4406
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
packages/dnb-eufemia/src/extensions/forms/Field/String/stories/String.stories.tsx
Outdated
Show resolved
Hide resolved
@@ -45,6 +45,9 @@ fieldset.dnb-forms-field-block { | |||
&--width { | |||
&-stretch { | |||
flex-grow: 1; | |||
.dnb-forms-field-block__label.dnb-form-label { | |||
max-width: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max-width: none; | |
max-width: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto
is not a possible value.
But perhaps I should use stretch
?
https://developer.mozilla.org/en-US/docs/Web/CSS/max-width#syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stretch
is not supported across all browsers yet.
packages/dnb-eufemia/src/components/date-picker/DatePickerCalendar.tsx
Outdated
Show resolved
Hide resolved
packages/dnb-eufemia/src/components/date-picker/DatePickerCalendar.tsx
Outdated
Show resolved
Hide resolved
…/String.stories.tsx Co-authored-by: Tobias Høegh <tobias@tujo.no>
…-field-block.scss Co-authored-by: Tobias Høegh <tobias@tujo.no>
I'll add a screenshot test as well |
## [10.61.0](v10.60.1...v10.61.0) (2024-12-13) ### 📝 Documentation * add guidelines for writing commit messages to the contribution guide ([#4389](#4389)) ([34eff0e](34eff0e)) * **Upload:** add `id` property ([#4401](#4401)) ([56d4956](56d4956)) ### ✨ Features * **Forms:** add missing support for `defaultValue` for Field.Slider ([#4394](#4394)) ([701ab66](701ab66)) * **Logo:** update sbanken logo ([#4379](#4379)) ([069ae1a](069ae1a)) * **Upload:** make `id` property as optional ([#4405](#4405)) ([0c58973](0c58973)) * **Value.Upload:** add async `onFileClick` event ([#4397](#4397)) ([be1c21c](be1c21c)) ### 🐛 Bug Fixes * **DatePicker:** add `null` as possible date type as return value ([#4407](#4407)) ([363e0b5](363e0b5)) * **DatePicker:** throw error when `date` is invalid ([#4396](#4396)) ([f977ebc](f977ebc)) * **FieldBlock:** remove max-width for label when width stretch ([#4406](#4406)) ([20c02d4](20c02d4)) * **Forms:** enhance transformIn and transformOut to support changed array and object instances ([#4392](#4392)) ([ae4648a](ae4648a)), closes [#4366](#4366) * **Slider:** ensure `min` and `max` value is respected when `step` doesn't fit exactly ([#4395](#4395)) ([2c00b0c](2c00b0c)) * **Tabs:** ensure cached content never takes up visual space ([#4399](#4399)) ([360aacc](360aacc)) * **Upload:** display files without anchor when their size is not given ([#4390](#4390)) ([70df7c8](70df7c8)) * **Upload:** display spinner in async `onFileClick` without file `id` ([#4393](#4393)) ([b743d6e](b743d6e))
🎉 This PR is included in version 10.61.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
the max-width for label was introduced in https://github.com/dnbexperience/eufemia/pull/4282/files#diff-2e86bd23f4e967469a410c825ff88987ca24029879ae97b6940fee744e08296dR74