Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker): add null as possible date type as return value #4407

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Dec 13, 2024

In the following CSB using 10.60.1, when removing the date from the input field using the keyboard, you can eventually get a date with the value of null back.
Hence updating the type to reflect this.

Slack thread: https://dnb-it.slack.com/archives/CMXABCHEY/p1734097311924599

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 2:39pm

@langz langz force-pushed the fix/adds-null-as-possible-value-for-return-date branch from 763156c to 2b77121 Compare December 13, 2024 14:16
@langz langz changed the title fix(DatePicker): add null as possible date type as return value fix(DatePicker): add null as possible date type as return value Dec 13, 2024
@langz langz requested a review from tujoworker December 13, 2024 14:21
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz merged commit 363e0b5 into main Dec 13, 2024
10 checks passed
@langz langz deleted the fix/adds-null-as-possible-value-for-return-date branch December 13, 2024 14:42
tujoworker pushed a commit that referenced this pull request Dec 13, 2024
## [10.61.0](v10.60.1...v10.61.0) (2024-12-13)

### 📝 Documentation

* add guidelines for writing commit messages to the contribution guide ([#4389](#4389)) ([34eff0e](34eff0e))
* **Upload:** add `id` property ([#4401](#4401)) ([56d4956](56d4956))

### ✨ Features

* **Forms:** add missing support for `defaultValue` for Field.Slider ([#4394](#4394)) ([701ab66](701ab66))
* **Logo:** update sbanken logo ([#4379](#4379)) ([069ae1a](069ae1a))
* **Upload:** make `id` property as optional ([#4405](#4405)) ([0c58973](0c58973))
* **Value.Upload:** add async `onFileClick` event ([#4397](#4397)) ([be1c21c](be1c21c))

### 🐛 Bug Fixes

* **DatePicker:** add `null` as possible date type as return value ([#4407](#4407)) ([363e0b5](363e0b5))
* **DatePicker:** throw error when `date` is invalid ([#4396](#4396)) ([f977ebc](f977ebc))
* **FieldBlock:** remove max-width for label when width stretch ([#4406](#4406)) ([20c02d4](20c02d4))
* **Forms:** enhance transformIn and transformOut to support changed array and object instances ([#4392](#4392)) ([ae4648a](ae4648a)), closes [#4366](#4366)
* **Slider:** ensure `min` and `max` value is respected when `step` doesn't fit exactly ([#4395](#4395)) ([2c00b0c](2c00b0c))
* **Tabs:** ensure cached content never takes up visual space ([#4399](#4399)) ([360aacc](360aacc))
* **Upload:** display files without anchor when their size is not given ([#4390](#4390)) ([70df7c8](70df7c8))
* **Upload:** display spinner in async `onFileClick` without file `id` ([#4393](#4393)) ([b743d6e](b743d6e))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants