Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

IP address filtering UI is not reflecting the settings correctly #1078

Closed
11 of 13 tasks
tingung opened this issue Aug 1, 2019 · 3 comments
Closed
11 of 13 tasks

IP address filtering UI is not reflecting the settings correctly #1078

tingung opened this issue Aug 1, 2019 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@tingung
Copy link
Contributor

tingung commented Aug 1, 2019

Description of bug

IP address filtering UI is not reflecting the settings correctly.

Steps to reproduce

List the steps to reproduce the behavior:

  1. Go to Settings -> Security -> Member Accounts -> Member Management
  2. Toggle "On" Enable IP Address Checking And Save
  3. Go to Settings -> Security -> Login Settings ->Login IP Filters
  4. Click "Add New Filters"
  5. Enter 192.168.0.1 into "First IP"
  6. Click "Save"
  7. Edit the filter

Current result

First IP input text field is blank. Similar behavior for other fields.

Expected result

First IP input text field should display the saved value. Other fields should display the saved value.

Screenshots

If applicable, provide screenshots to help explain your problem.
image
Reproduction video - https://drive.google.com/open?id=140U9IJAe5kN4SIgxRzIy6fe2GBUgoYHE

Error log

Paste the error log that is related to this issue.

Additional context

Add any other context about the bug that may be helpful for resolution.

Affected version

  • 9.3.2
  • 9.3.1
  • 9.2.2
  • 9.2.1
  • 9.2
  • 9.1.1
  • 9.1
  • 9.0

Affected browser

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer
  • Edge
@valadas
Copy link
Contributor

valadas commented Aug 1, 2019

Oh, I just saw this after duplicating the issue, ignore the other one...

This relates to dnnsoftware/Dnn.Platform#2922 which also needs to be fixed for this to work properly.

@valadas valadas added the bug Something isn't working label Aug 1, 2019
@valadas valadas added this to the 9.4.1 milestone Aug 1, 2019
@tingung
Copy link
Contributor Author

tingung commented Aug 2, 2019

Hi @valadas ,

I will fix 2922 with another PR because it need to change not only the UI validation but the server side. This issue is not reported by the client but I found it when I am manually test the IP Filter.

@valadas
Copy link
Contributor

valadas commented Sep 18, 2019

Merged

@valadas valadas closed this as completed Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants