Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'No search results' text shown although no search was performed. #3184

Closed
3 tasks done
dinesh-jain-aurea opened this issue Oct 21, 2019 · 1 comment
Closed
3 tasks done

Comments

@dinesh-jain-aurea
Copy link
Contributor

Description of bug

'No search results' message was shown although no search was performed. When a 'Search Module' is added to a page, the message 'No search results' is shown every time that page is loaded even though there is no search performed.

Steps to reproduce

List the steps to reproduce the behavior:

  1. Add the Search Module to the home page.
  2. After the page reloads by itself, the text 'No search results' is shown when no search was performed.
  3. At any time the home page loads, the text 'No search results' will be shown.

Current result

'No search results' message was shown although no search was performed.

Expected result

No message should be shown unless a search is performed. As per current behavior we do not perform search if the search query is less than 2 characters.

Screenshots

Screenshots after the fix and showing all conditions

No message shown when no search performed.
NoMessageWhenNoSearchPerformed

Valid Search Shown when search performed
ValidSearchresults

Message shown when Invalid search is performed
MessageWhenInvalidSearch

Affected version

  • 10.0.0 alpha build
  • 9.4.1 alpha build
  • 9.4.0 latest supported release
@valadas
Copy link
Contributor

valadas commented Oct 28, 2019

Merged

@valadas valadas closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants