Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing SMTP uses old logic #3813

Closed
1 task
thabaum opened this issue Jun 5, 2020 · 0 comments · Fixed by #3812 or #4089
Closed
1 task

Testing SMTP uses old logic #3813

thabaum opened this issue Jun 5, 2020 · 0 comments · Fixed by #3812 or #4089
Milestone

Comments

@thabaum
Copy link
Contributor

thabaum commented Jun 5, 2020

Description of bug

Provide a clear and concise description of the bug.
#3237

Steps to reproduce

List the precise steps to reproduce the bug:

  1. send test emails with different configurations of portal/host
  2. if host email is not set even when using portal smtp settings the test will fail

Current behavior

The smtp test is using host settings to and from email addresses only for testing emails
Setting another domain that is not allowed to send emails as host email will potentially break portal smtp settings.

Expected behavior

Portal settings for to and from addresses send emails from site security administrator account or host account.

Error information

Blank Host Email in Host SMTP Settings will cause an error currently while trying to test smtp using portal settings. Logged in as host during this test. I set different email addresses

Additional context

I set different email addresses in a variety of ways and configurations to see which emails are being used and when and it reminded me of previous fix I had done. I may have only tested while logged in as an administrator and not as host so this is why it still acts this way while logged in as host. It checks if host or not so things should work as intended similar to when you are logged in as admin (still need to test that theory of admin or host uses two different test SMTP methods/files as the names of the files may insist on) with the PR fix submitted. (still need to test that theory of admin or host uses two different test SMTP methods/files as the names of the files may insist on)

This could be when logged in as host, when you are an admin maybe it worked. I think the same logic should work in this location as well to set things right. I know it worked before I will test as an administrator rather than host see if it makes a difference.

Affected version

  • 10.00.00 alpha build (in development)
  • [ x ] 09.06.01 latest supported release

Affected browser

  • [ x ] Chrome
  • [ x ] Firefox
  • [ x] Safari
  • [ x ] Internet Explorer 11
  • [x ] Microsoft Edge (Classic)
  • [ x] Microsoft Edge Chromium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants