Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Tag Connector Track for Admin Issues #4867

Closed
6 of 9 tasks
cklenk opened this issue Oct 7, 2021 · 9 comments
Closed
6 of 9 tasks

Google Tag Connector Track for Admin Issues #4867

cklenk opened this issue Oct 7, 2021 · 9 comments

Comments

@cklenk
Copy link

cklenk commented Oct 7, 2021

Description of bug

When you first set up a Google Tag Manager Connection and enter a GTM id and hit save without checking the track for administrators. GTM will still load for admins. But if you check track for admins, hit save. Reload and go back and uncheck track for admins it finally stops loading GTM for admins.

Steps to reproduce

  1. Go to Settings > Connectors > Google Tag Manager
  2. Ensure a tracking code is added
  3. Leave change track for admins to false (default)
  4. Press save
  5. Check dom and see GTM still loads

Current behavior

GTM is still loading for admins even though track for admins is false (not checked)

Expected behavior

Expect it to not load GTM if that is not checked.

Error information

No errors, just does not what one expects.

Additional context

Wondering if this is related to #2782?

Affected version

  • 10.00.00 alpha build
  • 09.10.02 release candidate
  • 09.10.01 latest supported release

Affected browser

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 11
  • Microsoft Edge (Classic)
  • Microsoft Edge Chromium
@stale
Copy link

stale bot commented Jan 9, 2022

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Jan 9, 2022
@cklenk
Copy link
Author

cklenk commented Jan 18, 2022

Still an issue.

Thanks
-Cameron

@stale stale bot removed the stale label Jan 18, 2022
@stale
Copy link

stale bot commented Apr 18, 2022

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Apr 18, 2022
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been closed automatically due to inactivity (as mentioned 14 days ago). Feel free to re-open the issue if you believe it is still relevant.

@cklenk
Copy link
Author

cklenk commented Sep 7, 2022

Can we re-open this one? It's still an issue.

Thanks
-Cameron

@Constantine-Ketskalo
Copy link

Just in case someone needs it: I've created a duplicate (didn't find this one in search), where I've described what I've found out in the xml file in settings which seems to be a root cause. So whoever's going to work on it check it out if you need it:
#5198

P.S. Hope it's going to be fixed sooner then closed automatically for inactivity. ) It's been a long time already...

@valadas
Copy link
Contributor

valadas commented Sep 8, 2022

Reopened sir

@valadas valadas reopened this Sep 8, 2022
@stale stale bot removed the stale label Sep 8, 2022
@valadas valadas modified the milestones: 9.11.1, Future: Patch Jan 18, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Jun 18, 2023
@valadas
Copy link
Contributor

valadas commented Jun 18, 2023

This was fixed in #5669 Please test v9.12.0 latest rc and report back if you find any issues.

@valadas valadas closed this as completed Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants