Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when saving analytics connector settings when Track for Administrators checkbox is unchecked #5667

Closed
10 tasks done
david-poindexter opened this issue Jun 11, 2023 · 3 comments · Fixed by #5669
Closed
10 tasks done

Bug when saving analytics connector settings when Track for Administrators checkbox is unchecked #5667

david-poindexter opened this issue Jun 11, 2023 · 3 comments · Fixed by #5669
Labels
Effort: Medium Priority: High Status: New Type: Bug
Milestone
9.12.0

Comments

@david-poindexter
Copy link
Contributor

Description of bug

There is currently a bug when attempting to save any of the analytics connectors settings when "Track for Administrators" is unchecked.

Steps to reproduce

  1. Go to Settings > Connectors
  2. Edit settings for Google Analytics, Google Analytics 4, or Google Tag Manager connector
  3. Ensure Track for Administrators is unchecked
  4. Click `Save
  5. See console error

Current behavior

Will not save settings and throws console error.

Expected behavior

Provide a clear and concise description of the expected behavior.

Screenshots

image

Error information

See screenshot.

Additional context

This seems to have surfaced in DNN 9.11.0. It was working in DNN 9.10.2.

Affected version

  • 10.00.00 alpha build
  • 09.11.00
  • 09.11.01
  • 09.11.02 latest supported release

Affected browser

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 11
  • Microsoft Edge (Classic)
  • Microsoft Edge Chromium
@david-poindexter david-poindexter added this to the Future: Patch milestone Jun 11, 2023
@david-poindexter david-poindexter changed the title Bug when saving analytics connector settings when track for admins checkbox is unchecked Bug when saving analytics connector settings when Track for Administrators checkbox is unchecked Jun 11, 2023
@bdukes bdukes mentioned this issue Jun 12, 2023
Merged
@Timo-Breumelhof
Copy link
Contributor

This fix is not part of 09.12.00 is it? We used the "old analytics" connector for a lot of our clients...

@bdukes
Copy link
Contributor

bdukes commented Jun 23, 2023

Yes, this fix is part of 9.12.0

@Timo-Breumelhof
Copy link
Contributor

@bdukes ok thank you :-)

@bdukes bdukes modified the milestones: Future: Patch, 9.12.0 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort: Medium Priority: High Status: New Type: Bug
Projects
None yet
Milestone
9.12.0
Development

Successfully merging a pull request may close this issue.

Fixed an issue with the connectors checkboxes not saving properly bdukes/Dnn.Platform
3 participants
@bdukes @david-poindexter @Timo-Breumelhof