Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fly-out menus on the PersonaBar should be made visible to users of assistive technology #3051

Closed
5 tasks done
OllyHodgson opened this issue Aug 16, 2018 · 2 comments
Closed
5 tasks done

Comments

@OllyHodgson
Copy link
Contributor

Description of problem

Part of issue dnnsoftware/Dnn.AdminExperience#21. The fly-out menus on the PersonaBar should be made visible to users of assistive technology.

Description of solution

The <li> elements in the main personabar should make use of aria-haspopup='true' and aria-expanded='false' attributes if they have a sub-menu. The aria-expanded attribute should be set to true when the sub-menu is open.

Additional context

I suspect the attributes (and their default values) could be added using the data-bind attribute in the PersonaBar's index.html. Dynamically updating the aria-expanded attribute could be handled in main.js.

Affected version

  • 9.2.1
  • 9.2
  • 9.1.1
  • 9.1
  • 9.0

Affected browser

All browsers.

@valadas valadas transferred this issue from dnnsoftware/Dnn.AdminExperience Oct 2, 2019
@valadas valadas added this to the 9.4.2 milestone Oct 2, 2019
@valadas valadas modified the milestones: 9.4.2, 9.4.3 Nov 5, 2019
@valadas valadas modified the milestones: 9.4.3, 9.5.0 Nov 21, 2019
@valadas valadas modified the milestones: 9.5.0, 9.5.1 Jan 30, 2020
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Mar 18, 2020
@valadas valadas modified the milestones: 9.6.0, 9.6.1 Apr 14, 2020
@valadas valadas modified the milestones: 9.6.1, 9.6.2 May 7, 2020
@valadas valadas modified the milestones: 9.6.2, 9.7.0 Jun 25, 2020
@valadas valadas modified the milestones: 9.7.0, Future: Minor Jul 28, 2020
@stale
Copy link

stale bot commented Oct 28, 2020

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Oct 28, 2020
@stale
Copy link

stale bot commented Nov 11, 2020

This issue has been closed automatically due to inactivity (as mentioned 14 days ago). Feel free to re-open the issue if you believe it is still relevant.

@stale stale bot closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants