Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_maxima() fails when no downcrossings are found #125

Closed
eneelo opened this issue May 24, 2024 · 0 comments · Fixed by #127
Closed

find_maxima() fails when no downcrossings are found #125

eneelo opened this issue May 24, 2024 · 0 comments · Fixed by #127
Assignees
@eneelo
Labels
bug Something isn't working gui Issue is related to GUI

Comments

@eneelo
Copy link
Collaborator

eneelo commented May 24, 2024

Describe the bug
qats.signal.find_maxima() fails when the timeseries has no downcrossings, which in turn causes issues for plotting the time series in the GUI.

To Reproduce
HOLD - to be described

Expected behavior
The absence of downcrossings (and therefore absence of global maxima) should be handled, both in find_maxima() and in GUI.

Screenshots
image

image

Additional context
This bug was introduced in version 4.12.1, through pull request #109.
@eneelo eneelo added bug Something isn't working gui Issue is related to GUI labels May 24, 2024
@eneelo eneelo self-assigned this May 24, 2024
@eneelo eneelo mentioned this issue Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eneelo eneelo

Labels
bug Something isn't working gui Issue is related to GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stats: handle absence of global maxima in signal dnvgl/qats
1 participant
@eneelo