Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken dependency for python 3.12 #134

Open
jorgenengelsen opened this issue Jan 7, 2025 · 6 comments · May be fixed by #133 or #135
Open

Broken dependency for python 3.12 #134

jorgenengelsen opened this issue Jan 7, 2025 · 6 comments · May be fixed by #133 or #135
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@jorgenengelsen
Copy link

Describe the bug

New release of pyside6 breaks dependencies. To fix it I locked pyside6 to 6.6.0

To Reproduce

When installing latest QATS on python 3.12:

I get the following error:

image

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows
  • Version: Tested with latest QATS and QATS 5.0.7

Additional context
Add any other context about the problem here.

@eneelo eneelo self-assigned this Jan 7, 2025
@eneelo eneelo added the bug Something isn't working label Jan 7, 2025
@eneelo
Copy link
Collaborator

eneelo commented Jan 7, 2025

Hi, thanks for reporting.

I presume this was produced with poetry install? If so, on which branch?

I am not able to reproduce this behavior with python 3.12, neither with pip install qats nor with poetry install (using master branch, which corresponds to the latest release).

@jorgenengelsen
Copy link
Author

Hi, thanks for reporting.

I presume this was produced with poetry install? If so, on which branch?

I am not able to reproduce this behavior with python 3.12, neither with pip install qats nor with poetry install (using master branch, which corresponds to the latest release).

We discovered this bug across two machines here, testing with both 3.9 and 3.12. Seems like pip install qats in a clean venv works fine but using qats as a dependency in a minimal poetry example:

[project]
name = "testqats"
version = "0.1.0"
description = ""
authors = []
readme = "README.md"
requires-python = ">=3.10,<3.13"



[build-system]
requires = ["poetry-core>=2.0.0,<3.0.0"]
build-backend = "poetry.core.masonry.api"

then running

poetry add qats

Reproduces the error message:

image

@jorgenengelsen
Copy link
Author

When i try to pip install shiboken6, pip only finds shiboken 6.8.1. Not 6.8.8.1 as required.

Seems like windows wheels are missing from shiboken 6.8.8.1, as this is the only one distributed:

  • shiboken6-6.8.1.1-cp39-abi3-macosx_12_0_universal2.whl

@eneelo
Copy link
Collaborator

eneelo commented Jan 8, 2025

As far as I understand, this is caused by qats version 5.2.1 (=master branch) requiring pyside6 = "^6.6.0". According to https://python-poetry.org/docs/dependency-specification, this translates to pyside6 = ">=6.6.0,<7.0.0". When trying to install pyside6 version 6.8.x, it runs into the dependency issue that you have discovered. It beats me why poetry install on master branch in a clean environment doesn't reproduce it locally on my Windows PC.

On the good side; rerunning the tests for python 3.12 on PR #133, poetry install now fails for the same reason (it did not fail in December). See https://github.com/dnvgl/qats/actions/runs/12231614951/job/35295121808?pr=133. Hence, it is expected that issue may be closed upon the next qats release (after merging PR #133).

@eneelo
Copy link
Collaborator

eneelo commented Jan 8, 2025

Update: shiboken6 version 6.6.x doesn't seem to work well with numpy version 2.x. Allowing for pyside6 version 6.8 is therefore desirable. The following dependency, which avoids version 6.8.1.1 of pyside6 and shiboken6, seems to work well:
pyside6 = [ {version = ">=6.6.0,<=6.8.1", python = "<3.13"}, {version = "6.8.1", python = ">=3.13"} ]

A looser dependency, allowing for >=6.8.1, may be specified when this issue has been fixed on the pyside/shiboken side.

@eneelo eneelo linked a pull request Jan 8, 2025 that will close this issue
6 tasks
@jorgenengelsen
Copy link
Author

Update: shiboken6 version 6.6.x doesn't seem to work well with numpy version 2.x. Allowing for pyside6 version 6.8 is therefore desirable. The following dependency, which avoids version 6.8.1.1 of pyside6 and shiboken6, seems to work well: pyside6 = [ {version = ">=6.6.0,<=6.8.1", python = "<3.13"}, {version = "6.8.1", python = ">=3.13"} ]

A looser dependency, allowing for >=6.8.1, may be specified when this issue has been fixed on the pyside/shiboken side.

Thanks for following up. Locking the dependency to 6.8.1 on our side is a ok workaround for now.

@eneelo eneelo added dependencies Pull requests that update a dependency file and removed bug Something isn't working labels Jan 8, 2025
@eneelo eneelo linked a pull request Jan 23, 2025 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants