-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launchpad does not allow fetching arbitrary commits, which now breaks our tests here #25
Comments
Ok, I took both commits from https://github.com/docker-library/meta-scripts/blob/b446700b3ec0b10ef89204ab585ceb862f131da5/.test/library/ubuntu ( I'll make a PR fixing our test shortly. |
Did the behavior of Launchpad change? Why is this test failing now but was not before? |
See docker-library/official-images#13090 (comment) and following comments -- they only keep a few of their branches (per our request) so users can still inspect slightly older images, but not significantly older ones and this one just crossed the threshold with their update yesterday. |
We can fix this in a few different ways. The easiest/quickest temporary fix would be to mirror those old commits to a GitHub repository somewhere and update our test library file to reference it from GitHub instead (I still have these commits locally, so that would be pretty easy -- choosing/naming a repo is much harder; we used to use https://github.com/docker-library/commit-warehouse for this, before GitHub added support for fetching arbitrary commits and before it grew too large to even use anymore 😇).
A better long-term fix would probably be to finally convert
busybox
over to useoci-import
(now that we have #20) which would also allow us to test #20 properly. 😄The text was updated successfully, but these errors were encountered: