Explicitly set jemalloc's page size to the values Debian uses for their builds #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir builds Also, this adds the explicit `--build` flag to `./configure` for the bundled jemalloc, since we technically do cross-builds for 32bit architectures and this helps `./configure` understand that (and do userspace detection instead of kernel detection) better.
Closed
yosifkit
approved these changes
Oct 7, 2020
|
I pushed a build of this for testing to |
|
Confirmation in #208 (comment), thundercats are go! |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Oct 26, 2020
Changes: - redis/docker-library-redis@87e1fab: Merge pull request redis/docker-library-redis#254 from infosiftr/jemalloc - redis/docker-library-redis@ba0294e: Explicitly set jemalloc's page size to the values Debian uses for their builds
wy65701436
added a commit
to wy65701436/harbor-arm
that referenced
this pull request
Aug 31, 2021
In the arm env, redis needs to set the --with-lg-page=16 --with-lg-hugepage=21 when to build jemalloc For details, needs to refer to: redis/docker-library-redis#254 Signed-off-by: Wang Yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor-arm
that referenced
this pull request
Aug 31, 2021
In the arm env, redis needs to set the --with-lg-page=16 --with-lg-hugepage=21 when to build jemalloc For details, needs to refer to: redis/docker-library-redis#254 Signed-off-by: Wang Yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor-arm
that referenced
this pull request
Aug 31, 2021
In the arm env, redis needs to set the --with-lg-page=16 --with-lg-hugepage=21 when to build jemalloc For details, needs to refer to: redis/docker-library-redis#254 Note: 1. The rmp build must be executed on an arm based environment. 2. The make check in the redis source is disabled as the new parameters will fail the jemalloc test, it needs more investigation. Signed-off-by: Wang Yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor-arm
that referenced
this pull request
Aug 31, 2021
In the arm env, redis needs to set the --with-lg-page=16 --with-lg-hugepage=21 when to build jemalloc For details, needs to refer to: redis/docker-library-redis#254 Note: 1. The rmp build must be executed on an arm based environment. 2. The make check in the redis source is disabled as the new parameters will fail the jemalloc test, it needs more investigation. Signed-off-by: Wang Yan <wangyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this adds the explicit
--buildflag to./configurefor the bundled jemalloc, since we technically do cross-builds for 32bit architectures and this helps./configureunderstand that (and do userspace detection instead of kernel detection) better.Fixes #208