Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge up with our repo. #90

Closed
frank-dspeed opened this issue Aug 31, 2017 · 3 comments
Closed

Merge up with our repo. #90

frank-dspeed opened this issue Aug 31, 2017 · 3 comments

Comments

@frank-dspeed
Copy link

Hi i am Maintainer of this

Tianon we know us from the early docker days lets partner up and merge all our stuff that usefull into your image and maintain it together we have much done in start scripts already and also want to refactor to external nginx so this would be a ideal fit. maybe we could meet on irc for discussion? what do you think?

@yosifkit
Copy link
Member

Looking over the image I am not sure I see where they could be merged. There seems to be a lot of code dealing with automation and config management in your image, where we try to stick to a minimal image that can be extended. We'd definitely not want an image in official-images that includes supervisor to run multiple services in one container.

@frank-dspeed
Copy link
Author

@yosifkit we also don't want that anymore 👍 but your right we should use your image as base image and put our automation on top maybe

@tianon
Copy link
Member

tianon commented Apr 20, 2018

Glad to see this was resolved. 👍

@tianon tianon closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants