-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] rename repository branches #10079
Comments
Hey @thaJeztah 👋 We didn't communicate publicly on this, but this exactly what we decided. |
Ah, cool! Wonder if this must be done together with the deprecation, or if we could already do this (I think it should be generally non-disruptive, so perhaps there's no need to wait). |
Agreed! Would be nice to do this sooner rather than later. At first glance, I don't think anything would happen (any system automatically getting compose should be using the release URLs such as |
One warning; there was (or is?) a bug on GitHub, where renaming the branch does not update PRs that were opened from the web-ui (edit-button on GitHub). That workflow is probably less common on this repository as it is for the docs repository, but something to be aware of; see moby/mobywebsite#69 (comment) and docker/docs#14540 (comment) |
closing as done |
Description
Relates to
When development for Compose v2 (reimplementation in Go) moved to this repository, the
master
branch (in which the code for the (now in "maintenance mode") Python implementation lives, was kept, and a newv2
branch was created and set as default branch.Now that v2 is GA, and the default, we should consider:
master
tov1
v2
branch tomain
Opening this, as I have to fight muscle-memory every time I want to contribute to this repository 😂, and I can expect new contributors to this repository to also run into this (and possibly get confused).
go get github.com/docker/compose/v2@v2
to explicitly include the branch name), but I don't know if renaming the branch would have consequences for Python (don't think so?)The text was updated successfully, but these errors were encountered: